You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/17 05:27:07 UTC
[GitHub] [beam] damondouglas opened a new pull request, #22753: Update beam module dependency
damondouglas opened a new pull request, #22753:
URL: https://github.com/apache/beam/pull/22753
This PR fixes #22751 by updating the Beam SDK learning katas module dependency.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- ~Update `CHANGES.md` with noteworthy changes.~
- ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #22753: Go SDK Katas: Update beam module dependency
Posted by GitBox <gi...@apache.org>.
damondouglas commented on PR #22753:
URL: https://github.com/apache/beam/pull/22753#issuecomment-1217477679
R: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a diff in pull request #22753: Go SDK Katas: Update beam module dependency
Posted by GitBox <gi...@apache.org>.
damondouglas commented on code in PR #22753:
URL: https://github.com/apache/beam/pull/22753#discussion_r947470892
##########
build.gradle.kts:
##########
@@ -100,6 +100,8 @@ tasks.rat {
"**/*.json",
// Katas files
+ "learning/katas/**/course-info.yaml",
+ "learning/katas/**/task-info.yaml",
Review Comment:
IntelliJ edu course creation tool updates these files and removes the license. Whenever one updates anything in the course files, they would have to manually update the license information. These files only store metadata about the course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #22753: Go SDK Katas: Update beam module dependency
Posted by GitBox <gi...@apache.org>.
damondouglas commented on PR #22753:
URL: https://github.com/apache/beam/pull/22753#issuecomment-1226640636
@lostluck Thank you so much for reviewing this! We are in the process of building [Tour of Beam](https://github.com/apache/beam/pull/22794). So perhaps we can add course content there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22753: Go SDK Katas: Update beam module dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22753:
URL: https://github.com/apache/beam/pull/22753#issuecomment-1217478268
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #22753: Go SDK Katas: Update beam module dependency
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #22753:
URL: https://github.com/apache/beam/pull/22753#discussion_r954337303
##########
build.gradle.kts:
##########
@@ -100,6 +100,8 @@ tasks.rat {
"**/*.json",
// Katas files
+ "learning/katas/**/course-info.yaml",
+ "learning/katas/**/task-info.yaml",
Review Comment:
Makes sense! Lets not fight IntelliJ here, it's not a good use of anyone's time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #22753: Go SDK Katas: Update beam module dependency
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #22753:
URL: https://github.com/apache/beam/pull/22753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org