You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by rangadi <gi...@git.apache.org> on 2016/10/19 04:53:56 UTC
[GitHub] incubator-beam pull request #1133: [BEAM-777] KafkaIOTest : reader.start() c...
GitHub user rangadi opened a pull request:
https://github.com/apache/incubator-beam/pull/1133
[BEAM-777] KafkaIOTest : reader.start() can return false
KafkaIOTest expected reader.start() to always return true. It could return false as well (though most of the time it would succeed with MockConsumer).
updated `advanceOnce()` utility method to`start()` the reader based on a flag.
R: @dhalperi, R: @amitsela.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rangadi/incubator-beam fix_start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1133
----
commit 068e458d10c901fe1c299dffe84b75c9c842095c
Author: Raghu Angadi <ra...@google.com>
Date: 2016-10-19T04:46:18Z
KafkaIOTest : start() can return false
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1133: [BEAM-777] KafkaIOTest : reader.start() c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---