[GitHub] DaanHoogland commented on a change in pull request #2503: Support multiple volume access groups per compute cluster

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2503: Support multiple volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r184847397
 
 

 ##########
 File path: plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/SolidFireSharedPrimaryDataStoreLifeCycle.java
 ##########
 @@ -245,7 +243,7 @@ public DataStore initialize(Map<String, Object> dsInfos) {
 
         details.put(SolidFireUtil.VOLUME_ID, String.valueOf(sfVolume.getId()));
 
-        parameters.setUuid(iqn);
+        parameters.setUuid(UUID.randomUUID().toString());
 
 Review comment:
   so this is the only function change in this file amongst a lot of good cleanup. I known not enough of solidfire to judge its merits. Is there any chance you can split reformatting and functional changes to better my review capabilities?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services