You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/02/29 10:48:47 UTC

[GitHub] [incubator-heron] nwangtw opened a new pull request #3475: Add documents for setting up a docker based development environment

nwangtw opened a new pull request #3475: Add documents for setting up a docker based development environment
URL: https://github.com/apache/incubator-heron/pull/3475
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nicknezis merged pull request #3475: Add documents for setting up a docker based development environment

Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #3475: Add documents for setting up a docker based development environment
URL: https://github.com/apache/incubator-heron/pull/3475
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nicknezis commented on a change in pull request #3475: Add documents for setting up a docker based development environment

Posted by GitBox <gi...@apache.org>.
nicknezis commented on a change in pull request #3475: Add documents for setting up a docker based development environment
URL: https://github.com/apache/incubator-heron/pull/3475#discussion_r386533347
 
 

 ##########
 File path: website2/docs/compiling-docker.md
 ##########
 @@ -113,6 +113,39 @@ heron-layer-0.12.0-ubuntu14.04.tar
 heron-tools-0.12.0-ubuntu14.04.tar.gz
 ```
 
+## Set Up A Docker Based Development Environment
+
+In case you want to have a development environment instead of making a full build,
+Heron provides two helper scripts for you. It could be convenient if you don't want
+to set up all the libraries and tools on your machine directly.
+
+The following commands are to create a new docker image with a development environment
+and start the container based on it:
+```bash
+$ cd /path/to/heron/repo
+$ docker/scripts/dev-env-create.sh heron-dev
+```
+
+After the commands, a new docker container is started with all the libraries and tools
+installed. The operation system is Ubuntu 18.04 by default. Now you can build Heron
+like:
+```bash
+\# bazel build --config=ubuntu scripts/packages:binpkgs
+\# bazel build --config=ubuntu scripts/packages:tarpkgs
 
 Review comment:
   Is it worth mentioning the ability to use `--config=ubuntu_nostyle` as a way to cut down on the build time dedicated to static code analysis?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3475: Add documents for setting up a docker based development environment

Posted by GitBox <gi...@apache.org>.
nwangtw commented on a change in pull request #3475: Add documents for setting up a docker based development environment
URL: https://github.com/apache/incubator-heron/pull/3475#discussion_r386841627
 
 

 ##########
 File path: website2/docs/compiling-docker.md
 ##########
 @@ -113,6 +113,39 @@ heron-layer-0.12.0-ubuntu14.04.tar
 heron-tools-0.12.0-ubuntu14.04.tar.gz
 ```
 
+## Set Up A Docker Based Development Environment
+
+In case you want to have a development environment instead of making a full build,
+Heron provides two helper scripts for you. It could be convenient if you don't want
+to set up all the libraries and tools on your machine directly.
+
+The following commands are to create a new docker image with a development environment
+and start the container based on it:
+```bash
+$ cd /path/to/heron/repo
+$ docker/scripts/dev-env-create.sh heron-dev
+```
+
+After the commands, a new docker container is started with all the libraries and tools
+installed. The operation system is Ubuntu 18.04 by default. Now you can build Heron
+like:
+```bash
+\# bazel build --config=ubuntu scripts/packages:binpkgs
+\# bazel build --config=ubuntu scripts/packages:tarpkgs
 
 Review comment:
   Could be helpful to mention in comments I feel. I have never used this config. :D. Please feel free to create a PR for it. Thanks~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services