You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/25 21:15:39 UTC
[GitHub] [superset] betodealmeida opened a new pull request #14826: Update docs
betodealmeida opened a new pull request #14826:
URL: https://github.com/apache/superset/pull/14826
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Docs said that `mysql-connector-python` was recommended, but the SQLAlchemy docs say:
> The MySQL Connector/Python DBAPI has had many issues since its release, some of which may remain unresolved, and the mysqlconnector dialect is not tested as part of SQLAlchemy’s continuous integration. The recommended MySQL dialects are mysqlclient and PyMySQL.
I updated the docs to recommend `mysqlclient` (the previous recommendation), and to inform when `mysql-connector-python` might be needed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/superset/issues/14746
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #14826: chore: Update docs on MySQL recommended driver
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #14826:
URL: https://github.com/apache/superset/pull/14826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #14826: chore: Update docs on MySQL recommended driver
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #14826:
URL: https://github.com/apache/superset/pull/14826#discussion_r639218984
##########
File path: docs/src/pages/docs/Connecting to Databases/mysql.mdx
##########
@@ -8,16 +8,22 @@ version: 1
## MySQL
-The recommended connector library for MySQL is [mysql-connector-python](https://pypi.org/project/mysql-connector-python/).
+The recommended connector library for MySQL is [mysqlclient](https://pypi.org/project/mysqlclient/).
Here's the connection string:
```
-mysql+mysqlconnector://{username}:{password}@{host}/{database}
+mysql://{username}:{password}@{host}/{database}
```
Host:
- For Localhost or Docker running Linux: `localhost` or `127.0.0.1`
- For On Prem: IP address or Host name
- For Docker running in OSX: `docker.for.mac.host.internal`
Port: `3306` by default
+
+One problem with `mysqlclient` is that it will fail to connect to newer MySQL databases using `caching_sha2_password` for authentication, since the plugin is not included in the client. In the case, you should use [mysql-connector-python](https://pypi.org/project/mysql-connector-python/) instead:
Review comment:
```suggestion
One problem with `mysqlclient` is that it will fail to connect to newer MySQL databases using `caching_sha2_password` for authentication, since the plugin is not included in the client. In this case, you should use `[mysql-connector-python](https://pypi.org/project/mysql-connector-python/)` instead:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #14826: chore: Update docs on MySQL recommended driver
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #14826:
URL: https://github.com/apache/superset/pull/14826#discussion_r639219181
##########
File path: docs/src/pages/docs/Connecting to Databases/mysql.mdx
##########
@@ -8,16 +8,22 @@ version: 1
## MySQL
-The recommended connector library for MySQL is [mysql-connector-python](https://pypi.org/project/mysql-connector-python/).
+The recommended connector library for MySQL is [mysqlclient](https://pypi.org/project/mysqlclient/).
Review comment:
```suggestion
The recommended connector library for MySQL is `[mysqlclient](https://pypi.org/project/mysqlclient/)`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org