You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by xristosoik <gi...@git.apache.org> on 2015/06/07 18:14:09 UTC
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
GitHub user xristosoik opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/71
Addition of javadoc displaying in gremlin console
I create a package which implement all the necessary functionalities for parsing and displaying of javadocs in the gremlin console. Also I add 3 commands in the console which are responsible for the connection between console and package. Last but not least I create some test to verify the reliability.
The use of this commands is
// This is a command for loading of the documentation of a Class*.
gremlin> :importdocs "Graph"
//This is a command for displaying the documentation of a method**.
gremlin> :docs "addVertex"
//This id a command who returns the current loaded Class.
gremlin> :currdocs
*Every time is only one Class's loaded documentation.
** If there are overloaded classes displays all of them the one after the other.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xristosoik/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 16bb9a99810270c94ccc11178c40b0ac9a69c4f3
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-05-30T13:16:56Z
Addition of package DisplayDocs
commit 00a06367bf25eb95cea36a2103278392529a69a7
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-05-31T07:36:43Z
Addition of Javadocs
commit def7dfd428f01314645bf0e3c79fe42e209b5629
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-04T02:14:31Z
Correct parsing of documentation
commit 30cb24600c7d3057715a41d5325f362b1a739814
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-06T17:13:04Z
Merge branch 'master' of https://github.com/apache/incubator-tinkerpop
commit 140b8466115ad0b6e09903df1c51b9d05732d665
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-06T21:06:55Z
Addition of commands for the main functionality
commit 1c84a49dbf31acf3ac9f75bd913db96457cad74a
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-07T02:36:30Z
Fixing the displaying of methods
commit f30e142ab19c17fabda6bdc5448d61018e179db0
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-07T09:54:10Z
Addition of web parsing functionality
commit f3d59cac1a82ec2188018e8771f3aa9040512dcf
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-07T10:28:53Z
Addition of CurrDocsCommand.groovy
commit 816ee053f18cdf78c39692d138b9eadfe47f07ff
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-07T15:35:14Z
Fixing bugs and add unit tests
commit 77f2065fef32671a53e8636f1747fd5945f643f1
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-07T15:37:54Z
Merge branch 'webpage'
commit 4db216b7fe3c4288b1dc849219475216caacbee2
Author: xristosoik <ch...@dmst.aueb.gr>
Date: 2015-06-07T15:44:40Z
Merge branch 'master' of https://github.com/apache/incubator-tinkerpop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by xristosoik <gi...@git.apache.org>.
Github user xristosoik commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-130677732
I am sorry for the delayed answer! I have a lot of time pressure for my
work, so I haven't finished it. I am willing to but I need some time.
Sorry for any inconvenience
Regards,
Christos
> Where are we with this? Any movement? Ready to merge?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-126943079
×ñÞóôïò Ïéêïíüìïõ
ôçë. 6947359872
åíáëëáêôéêÞ äéåýèõíóç çëåêôñïíéêü ôá÷õäñïìåßï
chrikon1994@gmail.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #71: Addition of javadoc displaying in grem...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-222115764
We've had some discussion on the mailing list about this pull request:
https://lists.apache.org/thread.html/Zs1050tpg3vfz5n
and it seems the consensus is that we should probably close it at this point. Aside from it being nearly a year old without any additional activity, we think that this feature, if it were to exist, should be a feature of groovysh and not something tied to TinkerPop.
Unless you have concerns, I will close this pull request from my end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-110094093
After you've addressed the feedback, you might want to clean up this branch by rebasing to master in order to remove the various merge commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by xristosoik <gi...@git.apache.org>.
Github user xristosoik commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-154594514
I am intend to improve it by convert some part in groovy and add testing in as many part as it is possible(I have not forgot your feedback). However things had happened after this pull request and I did not have find any time to do all those I had planned to. Of course do not hesitate to tell me if you have any new ideas.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-154589905
@xristosoik I was wondering if you intend to come back to this pull request. it was the start of a nice body of work. any thoughts on how this could move forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by xristosoik <gi...@git.apache.org>.
Github user xristosoik commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-110110077
This will work but with the web parsing. There are 2 strategies the one is trying to find it local and the other is on web. The second is used only if the first fails. Although I will try your solution also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-110095398
Indentation looks a bit uneven. If you use IntelliJ or another code editor, it can probably clean that up for you automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Addition of javadoc displaying i...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/71#issuecomment-126943079
Where are we with this? Any movement? Ready to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---