You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ikatlinsky (via GitHub)" <gi...@apache.org> on 2023/06/05 10:25:34 UTC
[GitHub] [apisix-dashboard] ikatlinsky opened a new pull request, #2819: feat: allow to use env variables in config
ikatlinsky opened a new pull request, #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
This ticket adds an ability to use environment variables in the dashboard configuration using viper decode hooks. Such change is required to simplify dashboard configuration based on the environment type. For example can be useful to provide dashboard users and their passwords.
**Related issues**
[fix/resolve #0001](https://github.com/apache/apisix-dashboard/issues/2818)
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ikatlinsky commented on pull request #2819: feat: allow to use env variables in config
Posted by "ikatlinsky (via GitHub)" <gi...@apache.org>.
ikatlinsky commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1604327797
@juzhiyuan @bzp2010 @guoqqqi Sorry guys, can we proceed with this feature? Your reviews are very desired, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ikatlinsky commented on pull request #2819: feat: allow to use env variables in config
Posted by "ikatlinsky (via GitHub)" <gi...@apache.org>.
ikatlinsky commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1697769231
@bzp2010 @Baoyuantop hi, hope you will be able to check proposed changes, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2819: feat: allow to use env variables in config
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1652869443
Hello, I personally not available those months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ikatlinsky commented on pull request #2819: feat: allow to use env variables in config
Posted by "ikatlinsky (via GitHub)" <gi...@apache.org>.
ikatlinsky commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1651043465
@juzhiyuan @bzp2010 @guoqqqi up for review, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2819: feat: allow to use env variables in config
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1576663761
## [Codecov](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2819](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3134a7c) into [master](https://app.codecov.io/gh/apache/apisix-dashboard/commit/e0290c81cb3972978f0d1e3066db4d17dc6c14d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e0290c8) will **decrease** coverage by `11.47%`.
> The diff coverage is `88.88%`.
> :exclamation: Current head 3134a7c differs from pull request most recent head a6665dd. Consider uploading reports for the commit a6665dd to get more accurate results
```diff
@@ Coverage Diff @@
## master #2819 +/- ##
===========================================
- Coverage 77.49% 66.03% -11.47%
===========================================
Files 139 101 -38
Lines 3746 5152 +1406
Branches 881 269 -612
===========================================
+ Hits 2903 3402 +499
- Misses 843 1376 +533
- Partials 0 374 +374
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test-ginkgo | `65.32% <88.88%> (?)` | |
| frontend-e2e-test | `68.84% <ø> (-8.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `63.80% <88.88%> (ø)` | |
... and [176 files with indirect coverage changes](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2819/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ikatlinsky commented on pull request #2819: feat: allow to use env variables in config
Posted by "ikatlinsky (via GitHub)" <gi...@apache.org>.
ikatlinsky commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1576700805
@Gallardot can you please help with failing unit tests? Based on the logs I see
```
panic: couldn't open sink "logs/error.log": open logs/error.log: no such file or directory
```
which seems to be not related to my changes, can you point me in the right direction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ikatlinsky commented on pull request #2819: feat: allow to use env variables in config
Posted by "ikatlinsky (via GitHub)" <gi...@apache.org>.
ikatlinsky commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-1576729363
@Gallardot fixed the failing unit test, please approve workflow execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow to use env variables in config [apisix-dashboard]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on PR #2819:
URL: https://github.com/apache/apisix-dashboard/pull/2819#issuecomment-2813557819
I have to close this PR. Refer to https://github.com/apache/apisix-dashboard/issues/2981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow to use env variables in config [apisix-dashboard]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan closed pull request #2819: feat: allow to use env variables in config
URL: https://github.com/apache/apisix-dashboard/pull/2819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org