You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/02/17 21:07:19 UTC

[GitHub] alexhisen opened a new pull request #78: CB-12815: (ios) Bug fix in recent change in iOSExec.nativeCallback

alexhisen opened a new pull request #78: CB-12815: (ios) Bug fix in recent change in iOSExec.nativeCallback
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/78
 
 
   ### Platforms affected
   iOS
   
   ### Motivation and Context
   Now, callbackFromNative will actually get called async. Before it was not.
   See https://github.com/apache/cordova-plugin-wkwebview-engine/pull/49
   
   ### Description
   Use resolve.then() exactly same as in https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/src/www/ios/ios-wkwebview-exec.js
   
   ### Testing
   Works in an actual app
   
   ### Checklist
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org