[GitHub] [lucene-solr] dsmiley commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-727679559


   I'm looking at the docker image this produces closely, and I see it's more than a bit bloated thanks to this line:
   https://github.com/apache/lucene-solr/blob/3ae0ca23d937bef2865689748ac9e556b40aff38/solr/docker/Dockerfile#L45
   
       COPY --from=solr_package "/opt/solr-$SOLR_VERSION.tgz" "/opt/solr-$SOLR_VERSION.tgz"
   
   Which adds an entire layer of waste that is all of Solr 😱 
   
   I'm also a confused why we need an entire gradle module `:solr:docker:package` just for providing input to the Dockerfile.  I read the PR opening description which sort of says why it exists... but I think that could be provided all in one module using different tasks for the different steps.  I'm also not sure we need to support Dockerfile.release-package does since the image production process is merged with the project; it needn't download a .tgz from anywhere.  Right?  I don't think direct production of the image prohibits the goals stated above about producing an official image.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org