You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/01/16 19:59:59 UTC
Review Request 55588: [ATLAS-1464] Mechanism to include only specified
attributes in the notification message during entity create/update/delete
operations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55588/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Suma Shivaprasad.
Bugs: ATLAS-1464
https://issues.apache.org/jira/browse/ATLAS-1464
Repository: atlas
Description
-------
When entities are created/updated/deleted, a notification message is sent to notification listener informing of the operation and passing the entity object with all its attributes.
When size of the entity is greater than the max.request.size configured in Kafka, then the entity creation fails with "RecordTooLargeException"
A property needs to be set in atlas-application.properties to specify list of attributes to be included in the notification message sent to Kafka.
This patch check for property atlas.notification.entity.<atlas_type>.attributes.include in atlas-application.properties and if the property exists includes only the attributes listed in notification message
Diffs
-----
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java d10194d
Diff: https://reviews.apache.org/r/55588/diff/
Testing
-------
tested using POSTMAN rest client, created hive_db, hive_table and hive_column entities and only the attributes specified were sent in notification message.
Thanks,
Sarath Subramanian
Re: Review Request 55588: [ATLAS-1464] Mechanism to include only
specified
attributes in the notification message during entity create/update/delete
operations
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55588/#review161825
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java (line 168)
<https://reviews.apache.org/r/55588/#comment233127>
Instead of setting the attribute value to null, why don't we skip the attribute altogether. Currently, "someAttribute : null" would be present in the notification message which will take up space.
- Vimal Sharma
On Jan. 16, 2017, 7:59 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55588/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 7:59 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1464
> https://issues.apache.org/jira/browse/ATLAS-1464
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When entities are created/updated/deleted, a notification message is sent to notification listener informing of the operation and passing the entity object with all its attributes.
> When size of the entity is greater than the max.request.size configured in Kafka, then the entity creation fails with "RecordTooLargeException"
> A property needs to be set in atlas-application.properties to specify list of attributes to be included in the notification message sent to Kafka.
>
>
> This patch check for property atlas.notification.entity.<atlas_type>.attributes.include in atlas-application.properties and if the property exists includes only the attributes listed in notification message
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java d10194d
>
> Diff: https://reviews.apache.org/r/55588/diff/
>
>
> Testing
> -------
>
> tested using POSTMAN rest client, created hive_db, hive_table and hive_column entities and only the attributes specified were sent in notification message.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 55588: [ATLAS-1464] Mechanism to include only
specified
attributes in the notification message during entity create/update/delete
operations
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55588/#review161822
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 16, 2017, 7:59 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55588/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 7:59 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1464
> https://issues.apache.org/jira/browse/ATLAS-1464
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When entities are created/updated/deleted, a notification message is sent to notification listener informing of the operation and passing the entity object with all its attributes.
> When size of the entity is greater than the max.request.size configured in Kafka, then the entity creation fails with "RecordTooLargeException"
> A property needs to be set in atlas-application.properties to specify list of attributes to be included in the notification message sent to Kafka.
>
>
> This patch check for property atlas.notification.entity.<atlas_type>.attributes.include in atlas-application.properties and if the property exists includes only the attributes listed in notification message
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java d10194d
>
> Diff: https://reviews.apache.org/r/55588/diff/
>
>
> Testing
> -------
>
> tested using POSTMAN rest client, created hive_db, hive_table and hive_column entities and only the attributes specified were sent in notification message.
>
>
> Thanks,
>
> Sarath Subramanian
>
>