You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/06/25 15:36:00 UTC
[jira] [Commented] (SOLR-10778) Address precommit WARNINGS
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145028#comment-17145028 ]
David Smiley commented on SOLR-10778:
-------------------------------------
I just want to mention that I think it was a bit heavyweight to create JIRA issues for little things. This umbrella is fine but I'm referring to each sub-task. Basically, if it's not worth adding to CHANGES.txt (and these aren't), then it's probably not worth a JIRA either.
> Address precommit WARNINGS
> --------------------------
>
> Key: SOLR-10778
> URL: https://issues.apache.org/jira/browse/SOLR-10778
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.6
> Reporter: Andrew Musselman
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: dated-warnings, dated-warnings.log, notclosed.txt
>
>
> During precommit we are seeing lots of warnings. Im turning this into an umbrella issue about getting precommit warnings out of the code in general. Yes, this will take a while.
> See SOLR-10809 for getting all warnings out of solr/core. I want to selectively have precommit fail when "some part" of the code is clean so we don't backslide, and solr/core was the finest granularity I could see how to change.
> If you read more of the comments here, you can see that there are some serious code refactoring that could be done. I'm electing to simply SuppressWarnings rather than re-arrange code at this point whenever the code is tricky. If anyone goes back in and tries to clean the code up, then can remove the annotation(s).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org