[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3214: [linkis-engineplugin-pipeline] Modification of scala file floating red

[GitBox <gi...@apache.org>]

casionone commented on code in PR #3214:
URL: https://github.com/apache/incubator-linkis/pull/3214#discussion_r962106357


##########
linkis-engineconn-plugins/pipeline/src/main/scala/org/apache/linkis/manager/engineplugin/pipeline/executor/PipelineEngineConnExecutor.scala:
##########
@@ -60,7 +60,7 @@ class PipelineEngineConnExecutor(val id: Int) extends ComputationExecutor with L
     var succeedTasks = 1
     val newOptions = new util.HashMap[String, String]()
     newOptions.putAll(EngineConnObject.getEngineCreationContext.getOptions)
-    engineExecutorContext.getProperties.foreach { keyAndValue =>
+    engineExecutorContext.getProperties.asScala.foreach { keyAndValue =>
       newOptions.put(keyAndValue._1, keyAndValue._2.toString)
     }
     newOptions.foreach({ case (k, v) => logger.info(s"key is $k, value is $v") })

Review Comment:
   `PipelineEngineConnExecutor.scala:66: value foreach is not a member of java.util.HashMap[String,String]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org