You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2026/09/01 01:27:39 UTC
Re: [PR] GH-50899: [CI][C++] Use OIDC instead of ACCESS_KEY and SECRET_KEY for sccache's s3 creds [arrow]
kou commented on code in PR #51028:
URL: https://github.com/apache/arrow/pull/51028#discussion_r3899787074
##########
dev/tasks/macros.jinja:
##########
@@ -26,6 +26,7 @@ on:
env:
ARCHERY_DEBUG: 1
+ SCCACHE_OIDC_ROLE: {{ '${{ secrets.AWS_ROLE_ARN }}' }}
Review Comment:
Can we use `secrets.AWS_ROLE_ARN` directly instead of putting it to an environment variable?
##########
dev/tasks/macros.jinja:
##########
@@ -287,10 +288,21 @@ env:
{% endif %}
{%- endmacro -%}
+{%- macro github_configure_aws_credentials() -%}
+ - name: Configure AWS credentials for sccache
+ if: env.SCCACHE_OIDC_ROLE != ''
+ uses: aws-actions/configure-aws-credentials@v6
+ with:
+ aws-region: {{ '${{ secrets.SCCACHE_REGION }}' }}
+ role-to-assume: {{ '${{ env.SCCACHE_OIDC_ROLE }}' }}
+ role-duration-seconds: 14400
+{% endmacro %}
+
{% macro github_set_sccache_envvars(sccache_key_prefix = "sccache") %}
{% set sccache_vars = {
- "AWS_ACCESS_KEY_ID": '${{ secrets.AWS_ACCESS_KEY_ID }}',
- "AWS_SECRET_ACCESS_KEY": '${{ secrets.AWS_SECRET_ACCESS_KEY }}',
+ "AWS_ACCESS_KEY_ID": '${{ env.AWS_ACCESS_KEY_ID || secrets.AWS_ACCESS_KEY_ID }}',
+ "AWS_SECRET_ACCESS_KEY": '${{ env.AWS_SECRET_ACCESS_KEY || secrets.AWS_SECRET_ACCESS_KEY }}',
Review Comment:
Can we remove `|| secrets.AWS_*` if we always use OIDC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org