Re: Strict content type checking for REST and RPC endpoints

[Louis Ryan <lo...@gmail.com>]

This looks like a valid bug. Can you add it to JIRA?

On Sat, Jun 6, 2009 at 12:25 AM, <ro...@gmail.com> wrote:

> Has someone analyzed the side effects of this change on the existing
> container implmentations. I am having a problem with the sample conainer
> bundled with Shindig which uses application/x-www-form-urlencoded for
> setstate and setevilness calls.
>
> I am new to Shindig and may be wrong. Will be good if someone
> experienced verifies this -
> Line #117 in samplecontainer.js makes a call to the server -
>
>        sendRequestToServer('setstate', 'POST',
>            gadgets.io.encodeValues({
>                "fileurl" : stateFileUrl
>            }),
>            opt_callback);
>
> Which should be handled by SampleContainerHandler service, but gets
> blocked by ApiServlet and throws an error saying "Cannot use disallowed
> Content-Type application/x-www-form-urlencoded"
>
> These are the files effected -
>
> samplecontainer.html
> samplecontainer.js
> SampleContainerHandler.java
>
>
> On 2009/03/25 00:33:11, louiscryan wrote:
>
>> Updated as per comments. Committing
>>
>
>  http://codereview.appspot.com/28042/diff/1049/1065
>> File
>>
> java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java
>
>> (right):
>>
>
>  http://codereview.appspot.com/28042/diff/1049/1065#newcode200
>> Line 200: String contentType) throws InvalidContentTypeException {
>> On 2009/03/24 21:32:11, awiner wrote:
>> > checkContentTypes() - and all the constants - should be in a
>>
> separate class,
>
>> > injected into ApiServlet.  Or just into the subclasses where it's
>>
> used.
>
>> > I'd probably name it ContentTypes.
>>
>
>  Done.
>>
>
>  http://codereview.appspot.com/28042/diff/1049/1061
>> File
>>
>
>
> java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java
>
>> (right):
>>
>
>  http://codereview.appspot.com/28042/diff/1049/1061#newcode75
>> Line 75: * @return An object whos toString method will return json
>> On 2009/03/24 21:32:11, awiner wrote:
>> > whos/whose
>>
>
>  Done.
>>
>
>  http://codereview.appspot.com/28042/diff/1049/1061#newcode145
>> Line 145: return value instanceof String ?
>>
> Boolean.valueOf((String)value) :
>
>> Boolean.TRUE.equals(value);
>> On 2009/03/24 21:32:11, awiner wrote:
>> > space after )
>>
>
>  Done.
>>
>
>
>
> http://codereview.appspot.com/28042
>