[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #558: Fix bug missing Security Group in Advanced Zone with SG enabled

[GitBox <gi...@apache.org>]

utchoang commented on a change in pull request #558:
URL: https://github.com/apache/cloudstack-primate/pull/558#discussion_r461308461



##########
File path: src/views/compute/DeployVM.vue
##########
@@ -774,6 +780,9 @@ export default {
     },
     networkName () {
       return this.$route.query.name || null
+    },
+    showSecurityGroupSection () {
+      return this.networks.length > 0 && this.zone.securitygroupsenabled && this.hypervisor !== 'KVM'

Review comment:
       @davidjumani 
   I refer to https://github.com/apache/cloudstack/blob/master/ui/scripts/instanceWizard.js#L177 then I think KVM does not support it.

##########
File path: src/views/compute/DeployVM.vue
##########
@@ -774,6 +780,9 @@ export default {
     },
     networkName () {
       return this.$route.query.name || null
+    },
+    showSecurityGroupSection () {
+      return this.networks.length > 0 && this.zone.securitygroupsenabled && this.hypervisor !== 'KVM'

Review comment:
       @davidjumani I understood. I'll remove `this.hypervisor !== 'KVM'` condition. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org