You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2014/11/18 12:01:56 UTC
[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/1
keep colons in the request to ACS
ACS does not decode %3A to colon and thus some requests break
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack-cloudmonkey master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack-cloudmonkey/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit 5d5c88082b41cca113e9dd640c2d702f824d4fca
Author: Remi Bergsma <gi...@remi.nl>
Date: 2014-11-18T11:00:12Z
keep colons in the request to ACS
ACS does not decode %3A to colon and thus some requests break
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-cloudmonkey/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/1#issuecomment-63473873
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/1#issuecomment-63455032
is there a jira issue for it ? if yes we will need to close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/1#issuecomment-63460966
Created CLOUDSTACK-7935 for documentation purposes. See: https://issues.apache.org/jira/browse/CLOUDSTACK-7935
You can close this issue when you merge this change.
Thanks!
Remi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/1#issuecomment-63458765
I didn't create a ticket for it. Will do if you want me to :-)
Sent from my iPhone
> On 18 Nov 2014, at 12:13, runseb <no...@github.com> wrote:
>
> is there a jira issue for it ? if yes we will need to close it.
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---