You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tooling.apache.org by sb...@apache.org on 2026/10/22 13:13:57 UTC

(tooling-trusted-releases) branch sbp updated: Use fail safe curl flags on the vote page

This is an automated email from the ASF dual-hosted git repository.

sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git


The following commit(s) were added to refs/heads/sbp by this push:
     new 9bf1f41a Use fail safe curl flags on the vote page
9bf1f41a is described below

commit 9bf1f41a9b4215424f3292c7e27dbd7c7a3a682d
Author: Sean B. Palmer <se...@miscoranda.com>
AuthorDate: Thu Oct 22 14:12:25 2026 +0100

    Use fail safe curl flags on the vote page
---
 atr/get/vote.py            | 2 +-
 tests/e2e/vote/test_get.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/atr/get/vote.py b/atr/get/vote.py
index e0fa5eb2..96a77027 100644
--- a/atr/get/vote.py
+++ b/atr/get/vote.py
@@ -268,7 +268,7 @@ def _download_curl(release: sql.Release) -> htm.Element:
         project_key=release.project.key,
         version_key=release.version,
     )
-    curl_command = f"curl -s https://{app_host}{script_url} | sh"
+    curl_command = f"curl -fsS https://{app_host}{script_url} | sh"
 
     return htm.div(".mb-3")[
         htm.div(".mb-2")[htm.strong["Use curl:"]],
diff --git a/tests/e2e/vote/test_get.py b/tests/e2e/vote/test_get.py
index df79fb6b..2d6b436b 100644
--- a/tests/e2e/vote/test_get.py
+++ b/tests/e2e/vote/test_get.py
@@ -28,7 +28,7 @@ def test_browse_files_link_visible(page_vote: Page) -> None:
 def test_curl_command_contains_expected_text(page_vote: Page) -> None:
     """The curl command should contain the expected curl invocation."""
     command_text = helpers.get_curl_command_text(page_vote)
-    expect(command_text).to_contain_text("curl -s https://")
+    expect(command_text).to_contain_text("curl -fsS https://")
     expect(command_text).to_contain_text("| sh")
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org