[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41622: [SPARK-44064][SQL] Move `NonFateSharingCache` from `core` module to `catalyst` module

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41622:
URL: https://github.com/apache/spark/pull/41622#discussion_r1233416021


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/util/NonFateSharingCache.scala:
##########
@@ -15,13 +15,15 @@
  * limitations under the License.
  */
 
-package org.apache.spark.util
+package org.apache.spark.sql.util

Review Comment:
   I agree but seems like it causes some problem @LuciferYang pointed at here https://github.com/apache/spark/pull/40982#issuecomment-1594026021 if we move this to other modules (and catalyst module only has `sql` module). It doesn't look so beautiful but I think this is a minimized fix. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org