[GitHub] [arrow] fsaintjacques commented on a change in pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests

[GitBox <gi...@apache.org>]

fsaintjacques commented on a change in pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#discussion_r432476648



##########
File path: cpp/src/arrow/flight/flight_test.cc
##########
@@ -1556,13 +1556,14 @@ TEST_F(TestBasicAuthHandler, CheckPeerIdentity) {
   ASSERT_EQ(result->body->ToString(), "user");
 }
 
-#ifdef __APPLE__
-// ARROW-7701: this test is flaky on MacOS and segfaults (due to gRPC
-// bug?)
-TEST_F(TestTls, DISABLED_DoAction) {
-#else
 TEST_F(TestTls, DoAction) {
-#endif
+  // Manually initialize gRPC to try to ensure some thread-locals get
+  // initialized.
+  // https://github.com/grpc/grpc/issues/13856
+  // https://github.com/grpc/grpc/issues/20311
+  // In general, gRPC on MacOS struggles with TLS (both in the sense
+  // of thread-locals and encryption)
+  grpc_init();

Review comment:
       Can you move this in the test's fixture setup?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org