You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/05/20 04:31:23 UTC
Review Request 21678: Added static factory method to ExternalContainerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21678/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
The SlaveRecoveryTests expect a static factory method (create) to delegate the instantiation of the tested containerizer to its respective implementation. This patch adds that mathod.
Diffs
-----
src/slave/containerizer/external_containerizer.hpp afffff1
src/slave/containerizer/external_containerizer.cpp f9811c4
Diff: https://reviews.apache.org/r/21678/diff/
Testing
-------
make check (in upcoming EC test suite)
Thanks,
Till Toenshoff
Re: Review Request 21678: Added static factory method to
ExternalContainerizer.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21678/#review44224
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21678]
All tests passed.
- Mesos ReviewBot
On May 20, 2014, 2:31 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21678/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 2:31 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The SlaveRecoveryTests expect a static factory method (create) to delegate the instantiation of the tested containerizer to its respective implementation. This patch adds that mathod.
>
>
> Diffs
> -----
>
> src/slave/containerizer/external_containerizer.hpp afffff1
> src/slave/containerizer/external_containerizer.cpp f9811c4
>
> Diff: https://reviews.apache.org/r/21678/diff/
>
>
> Testing
> -------
>
> make check (in upcoming EC test suite)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21678: Added static factory method to
ExternalContainerizer.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21678/#review43696
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On May 19, 2014, 7:31 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21678/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 7:31 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The SlaveRecoveryTests expect a static factory method (create) to delegate the instantiation of the tested containerizer to its respective implementation. This patch adds that mathod.
>
>
> Diffs
> -----
>
> src/slave/containerizer/external_containerizer.hpp afffff1
> src/slave/containerizer/external_containerizer.cpp f9811c4
>
> Diff: https://reviews.apache.org/r/21678/diff/
>
>
> Testing
> -------
>
> make check (in upcoming EC test suite)
>
>
> Thanks,
>
> Till Toenshoff
>
>