You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/22 22:56:04 UTC
[GitHub] [beam] ibzib commented on a change in pull request #15555: Update release docs
ibzib commented on a change in pull request #15555:
URL: https://github.com/apache/beam/pull/15555#discussion_r714361345
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -139,7 +139,7 @@ fi
RC_TAG="v${RELEASE}-RC${RC_NUM}"
-USER_REMOTE_URL=git@github.com:${USER_GITHUB_ID}/beam-site
+USER_REMOTE_URL=https://${USER_GITHUB_ID}@github.com/${USER_GITHUB_ID}/beam-site.git
Review comment:
The @ part doesn't look right, shouldn't it be something like https://github.com/ibzib/beam-site ?
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -598,6 +609,10 @@ See the source of the script for more details, or to run commands manually in ca
Artifact names should follow [the existing format](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.beam%22) in which artifact name mirrors directory structure, e.g., `beam-sdks-java-io-kafka`.
Carefully review any new artifacts.
+__NOTE__: When uploading to Nexus using gradle, ip address is used as a seesion id. Incorrect partial artifact upload will result if the public ip of the dev machine changes during upload.
Review comment:
Please link the jira for this issue here if there is one.
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -567,6 +572,12 @@ See the source of the script for more details, or to run commands manually in ca
* Copy python doc into beam-site
* Copy java doc into beam-site
+
+* **Mitigate GPG Out Of Memory Error**
+ * gpg-agent might through Out Of Memory error. You can kill the gpg-agent to mitigate this issue.
Review comment:
```suggestion
* gpg-agent might throw Out Of Memory error. You can kill the gpg-agent to mitigate this issue.
```
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -471,6 +471,11 @@ For all other JIRA issues:
If there is a bug found in the RC creation process/tools, those issues should be considered high priority and fixed in 7 days.
+### Process for cherry-picks
+
+* Feature owner should first merge the changes in master and then create the cherry-pick from the merge commit against release branch. The cr should start have `[cherrypick]` in the title and release manager as the reviewer.
Review comment:
typo?
```suggestion
* Feature owner should first merge the changes in master and then create the cherry-pick from the merge commit against release branch. The PR should have `[cherrypick]` in the title and release manager as the reviewer.
```
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -567,6 +572,12 @@ See the source of the script for more details, or to run commands manually in ca
* Copy python doc into beam-site
* Copy java doc into beam-site
+
+* **Mitigate GPG Out Of Memory Error**
+ * gpg-agent might through Out Of Memory error. You can kill the gpg-agent to mitigate this issue.
Review comment:
Is there a jira for this? killing the agent is a workaround, but we should also plan to fix this permanently.
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -471,6 +471,11 @@ For all other JIRA issues:
If there is a bug found in the RC creation process/tools, those issues should be considered high priority and fixed in 7 days.
+### Process for cherry-picks
Review comment:
Nit: I don't think we need a new section for this, we can just add the first bullet point to the existing "Review cherry-picks" section.
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -598,6 +609,10 @@ See the source of the script for more details, or to run commands manually in ca
Artifact names should follow [the existing format](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.beam%22) in which artifact name mirrors directory structure, e.g., `beam-sdks-java-io-kafka`.
Carefully review any new artifacts.
+__NOTE__: When uploading to Nexus using gradle, ip address is used as a seesion id. Incorrect partial artifact upload will result if the public ip of the dev machine changes during upload.
Review comment:
```suggestion
__NOTE__: When uploading to Nexus using gradle, ip address is used as a session id. Incorrect partial artifact upload will result if the public ip of the dev machine changes during upload.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org