You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "warrenzhu25 (via GitHub)" <gi...@apache.org> on 2023/04/06 22:40:40 UTC

[GitHub] [spark] warrenzhu25 commented on a diff in pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

warrenzhu25 commented on code in PR #40687:
URL: https://github.com/apache/spark/pull/40687#discussion_r1160312654


##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -1357,7 +1357,7 @@ private[spark] object JsonProtocol {
           message.getOrElse("Unknown reason"))
       case `exceptionFailure` =>
         val className = json.get("Class Name").extractString
-        val description = json.get("Description").extractString
+        val description = jsonOption(json.get("Description")).map(_.extractString).orNull

Review Comment:
   I forget the context of this change. Let me revert this change, and double confirm. if this is needed, I'll send another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org