You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/03/27 16:40:35 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1495: SOLR-16720: Defer PKI header creation to send-time
gerlowskija opened a new pull request, #1495:
URL: https://github.com/apache/solr/pull/1495
https://issues.apache.org/jira/browse/SOLR-16720
# Description
Prior to this commit, the PKIAuthPlugin decorates outgoing requests at 'queue' time instead of later when they're actually sent. This can cause scenarios where, under heavy load, queue time and sending time are far enough apart that much or all of the TTL window for the outgoing request is expired by the time its even sent.
# Solution
This commit switches header-decoration to occur using a different lifecycle hook offered by Jetty, 'onBegin', so that it's done as close as possible to the actual time the request is sent.
This won't eliminate the possibility of errant TTL expiry, but should reduce it substantially under heavy load.
# Tests
Testing this is difficult, as it requires a heavy load profile to reproduce. Solr (rightfully) doesn't offer any way to patch or customize PKIAuthPlugin, which makes forcing a delay difficult. We may have to rely on manual testing and the existing test suite here, unless a novel idea arises?
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1495: SOLR-16720: Defer PKI header creation to send-time
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1495:
URL: https://github.com/apache/solr/pull/1495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org