Re: [I] File does not exist when we stop suppressing column metadata read failure [hudi]

["rangareddy (via GitHub)" <gi...@apache.org>]

rangareddy commented on issue #17206:
URL: https://github.com/apache/hudi/issues/17206#issuecomment-5366106889

   This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9800).
   
   **Findings: the experiment is still runnable as written; it needs to be run.**
   
   I confirmed the suppressing catch is still present and unchanged - it now sits at `hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:1262` rather than the line in your link, since the surrounding code has moved since commit `6ea636078ce1`:
   
   ```java
   } catch (Exception e) {
     // NOTE: In case reading column range metadata from individual file failed,
     //       we simply fall back, in lieu of failing the whole task
     log.error("Failed to fetch column range metadata for: {}", partitionPathFileName);
     return Collections.emptyList();
   }
   ```
   
   So the recipe still applies: throw from that catch instead of returning a list, then run `org.apache.hudi.functional.TestColumnStatsIndex#testMetadataColumnStatsIndexInitializationWithRollbacks`.
   
   What I have not done is run it, so whether the underlying "File does not exist" failure still occurs on current `master` is unconfirmed. Given the rollback and metadata-initialization paths have both changed substantially, that is worth establishing before designing a fix.
   
   **This is the blocking dependency for #17160 (HUDI-9722)**, which wants to narrow that catch to IO exceptions. Narrowing it before this is fixed would convert a silent failure into a broken metadata-table initialization, so these two should be worked together with this one first.
   
   Keeping this open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org