You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "rombert (via GitHub)" <gi...@apache.org> on 2024/03/26 08:51:13 UTC
[PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
rombert opened a new pull request, #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42
- remove shade plugin configuration
- stop embedding guava classes
- rework our overrides to no longer use Guava
Bundle size is down from 4.1 to 1.9 MB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2047647027
lgtm from sling-mock perspective
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert merged PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2020060352
> After this PR the bundle will no longer resolve in the current Sling Starter
>
> ```
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.xss:2.4.1-SNAPSHOT: Bundle is importing package org.owasp.shim with start order 20 but no bundle is exporting these for that start order.
> ```
Fixed with https://github.com/apache/sling-org-apache-sling-xss/pull/42/commits/a6efb27cdcfe2d9f3fdc85483847c1255de99c8a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2020438489
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=42) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=42&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss&pullRequest=42&resolved=false&inNewCodePeriod=true)
 [84.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=42)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2020330295
@kwin - my reading of the release notes is that this release still supports Java 8. The Jenkins build with Java 8 also passes - https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-xss/detail/PR-42/1/pipeline/122 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2020681234
https://github.com/OWASP/java-html-sanitizer/pull/328#issuecomment-2020675724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2049992800
@raducotescu - any comments? I plan to merge tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2022791382
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=42) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=42&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss&pullRequest=42&resolved=false&inNewCodePeriod=true)
 [84.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=42)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2019875037
After this PR the bundle will no longer resolve in the current Sling Starter
```
[ERROR] [bundle-packages] org.apache.sling:org.apache.sling.xss:2.4.1-SNAPSHOT: Bundle is importing package org.owasp.shim with start order 20 but no bundle is exporting these for that start order.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2020141938
java-html-sanitizer 20240325.1 contains Java 10 bytecode (https://github.com/OWASP/java-html-sanitizer/blob/43089899bae8fae0cb0016c5700beace7ddd26f0/owasp-java-html-sanitizer/pom.xml#L90), so we should target Java10+ as well with our wrapper bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2019856808
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=42) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=42&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss&pullRequest=42&resolved=false&inNewCodePeriod=true)
 [84.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=42&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=42)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org