You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/09/07 09:41:26 UTC

[GitHub] spark pull request #21618: [SPARK-20408][SQL] Get the glob path in parallel ...

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21618#discussion_r215903958
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala ---
    @@ -77,6 +80,51 @@ class SparkHadoopUtilSuite extends SparkFunSuite with Matchers {
         })
       }
     
    +  test("test expanding glob path") {
    --- End diff --
    
    IIUC, the new feature is disabled as default since `spark.sql.sources.parallelGetGlobbedPath.numThreads` is 0.
    
    I am afraid these test causes are executed only with disabling the new feature.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org