You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by persiaAziz <gi...@git.apache.org> on 2017/01/13 04:42:19 UTC

[GitHub] trafficserver pull request #1324: issue-1323: fix RecDataset

GitHub user persiaAziz opened a pull request:

    https://github.com/apache/trafficserver/pull/1324

    issue-1323: fix RecDataset

    set nullptr if a config specified to be NULL in records.config

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/persiaAziz/trafficserver issue-1323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1324
    
----
commit a87937602d44c79fbf533f641b36dc2502fe63f7
Author: Syeda Persia Aziz <pe...@yahoo.com>
Date:   2017-01-13T04:31:40Z

    issue-1323: fix RecDataset

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

Posted by atsci <gi...@git.apache.org>.

Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1324
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1329/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

Posted by persiaAziz <gi...@git.apache.org>.

Github user persiaAziz commented on the issue:

    https://github.com/apache/trafficserver/pull/1324
  
    yah no need to merge this since the actual problem is somewhere else. I just didn't want to master to be unstable, that is why I made this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

Posted by zwoop <gi...@git.apache.org>.

Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/1324
  
    Albeit reasonable, I don't think we should land this. There's a number of places from ced4da13279f834c381925f2ecd1649bfb459e8b which changes "NULL" to "nullptr" accidentally, and we should investigate each of those, and revert where appropriate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1324: issue-1323: fix RecDataset

Posted by zwoop <gi...@git.apache.org>.

Github user zwoop closed the pull request at:

    https://github.com/apache/trafficserver/pull/1324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

Posted by atsci <gi...@git.apache.org>.

Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1324
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1223/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---