You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/12/06 22:50:51 UTC
[PR] [fix][cli] Fix set-retention with >2GB size value for topic policy [pulsar]
lhotari opened a new pull request, #23689:
URL: https://github.com/apache/pulsar/pull/23689
### Motivation
Fixes a similar issue as #22150, for `pulsar-admin topics set-retention` and `pulsar-admin topicPolicies set-retention` commands. Related to #23688. This adds a test to #23688 changes.
### Modifications
- use long value instead of integer
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][cli] Fix set-retention with >2GB size value for topic policy [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23689:
URL: https://github.com/apache/pulsar/pull/23689#issuecomment-2556809037
> @lhotari
>
> If do not cherry-pick into `branch-3.0`, there is a downgrade compatibility issue:
>
> * upgrade to `4.0.x`
> * Set a larger value for the policy.
> * downgrade to `3.0.x`, the value will be transferred to a negative value,
@poorbarcode I don't think that this applies to 3.0.x since the regression was introduced in changes made in #20782 (and possibly #22209) which aren't part of 3.0.x. The issue #22138 was reported to be a regression in 3.2.0 . When we fixed this issue, we missed fixing it for topic policies and only fixed the namespace policies level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][cli] Fix set-retention with >2GB size value for topic policy [pulsar]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #23689:
URL: https://github.com/apache/pulsar/pull/23689#issuecomment-2556284522
@lhotari
If do not cherry-pick into `branch-3.0`, there is a downgrade compatibility issue:
- upgrade to `4.0.x`
- Set a larger value for the policy.
- downgrade to `3.0.x`, the value will be transferred to a negative value,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][cli] Fix set-retention with >2GB size value for topic policy [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #23689:
URL: https://github.com/apache/pulsar/pull/23689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][cli] Fix set-retention with >2GB size value for topic policy [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23689:
URL: https://github.com/apache/pulsar/pull/23689#issuecomment-2524684621
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23689?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `50.00000%` with `2 lines` in your changes missing coverage. Please review.
> Project coverage is 74.41%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4ce3296`)](https://app.codecov.io/gh/apache/pulsar/commit/4ce3296a8f2890fd0b3ecfc9cc60275db1009fed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 779 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/23689?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&filepath=pulsar-client-tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fadmin%2Fcli%2FCmdTopicPolicies.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWRUb3BpY1BvbGljaWVzLmphdmE=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/pulsar/admin/cli/CmdTopics.java](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&filepath=pulsar-client-tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fadmin%2Fcli%2FCmdTopics.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWRUb3BpY3MuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #23689 +/- ##
============================================
+ Coverage 73.57% 74.41% +0.84%
- Complexity 32624 35082 +2458
============================================
Files 1877 1945 +68
Lines 139502 147448 +7946
Branches 15299 16270 +971
============================================
+ Hits 102638 109724 +7086
- Misses 28908 29242 +334
- Partials 7956 8482 +526
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23689/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.42% <0.00%> (+2.84%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/23689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.40% <0.00%> (+0.07%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.79% <50.00%> (+0.94%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/23689?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&filepath=pulsar-client-tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fadmin%2Fcli%2FCmdTopicPolicies.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWRUb3BpY1BvbGljaWVzLmphdmE=) | `89.61% <50.00%> (ø)` | |
| [...in/java/org/apache/pulsar/admin/cli/CmdTopics.java](https://app.codecov.io/gh/apache/pulsar/pull/23689?src=pr&el=tree&filepath=pulsar-client-tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fadmin%2Fcli%2FCmdTopics.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWRUb3BpY3MuamF2YQ==) | `80.61% <50.00%> (-0.57%)` | :arrow_down: |
... and [664 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23689/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org