You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2021/10/17 20:21:49 UTC

[whimsy] branch master updated: Update parts.js.rb (#126)

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new ee89419  Update parts.js.rb (#126)
ee89419 is described below

commit ee894196cf3f2ecdf091ddc1b1cec6035e26eae1
Author: Craig L Russell <ap...@gmail.com>
AuthorDate: Sun Oct 17 13:21:41 2021 -0700

    Update parts.js.rb (#126)
    
    * Update parts.js.rb
    
    Remove "missing phone" from "incomplete ICLA"
    
    * Update parts.js.rb
    
    Remove @missing_phone from rest of code
    
    * Update incomplete.json.rb
    
    Remove @missing_phone
---
 www/secretary/workbench/views/actions/incomplete.json.rb | 3 +--
 www/secretary/workbench/views/parts.js.rb                | 9 ---------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/www/secretary/workbench/views/actions/incomplete.json.rb b/www/secretary/workbench/views/actions/incomplete.json.rb
index fbdbd74..84a8675 100644
--- a/www/secretary/workbench/views/actions/incomplete.json.rb
+++ b/www/secretary/workbench/views/actions/incomplete.json.rb
@@ -15,9 +15,8 @@ _extract_project
 task "email #{message.from}" do
   # build mail from template
   @email = message.from
-  @test2 = [@missing_phone, @missing_address]
+  @test2 = [@missing_address]
   missing_items = []
-  missing_items << '- missing phone number' if @missing_phone == 'true'
   missing_items << '- missing or incomplete postal address' if @missing_address == 'true'
   missing_items << '- missing email address' if @missing_email == 'true'
   missing_items << '' if missing_items.size > 0 # add separator
diff --git a/www/secretary/workbench/views/parts.js.rb b/www/secretary/workbench/views/parts.js.rb
index c54591c..3f9fe3a 100644
--- a/www/secretary/workbench/views/parts.js.rb
+++ b/www/secretary/workbench/views/parts.js.rb
@@ -12,7 +12,6 @@ class Parts < Vue
     @form = :categorize
     @menu = nil
     @project = nil
-    @missing_phone = false
     @missing_address = false
     @missing_email = false
   end
@@ -158,20 +157,12 @@ class Parts < Vue
               value: window.parent.location.pathname
             _input type: 'hidden', name: 'selected', value: @@selected
             _input type: 'hidden', name: 'signature', value: @@signature
-            _input type: 'hidden', name: 'missing_phone', value: @missing_phone
             _input type: 'hidden', name: 'missing_address', value: @missing_address
             _input type: 'hidden', name: 'missing_email', value: @missing_email
 
             spacer = "\u00A0"*4 # non-breaking space as UTF-8
             _label do
               _ spacer
-              _input type: 'checkbox', checked: @missing_phone,
-              onClick:-> {@missing_phone = !@missing_phone}
-              _span ' missing phone number'
-            end
-
-            _label do
-              _ spacer
               _input type: 'checkbox', checked: @missing_address,
               onClick:-> {@missing_address = !@missing_address}
               _span ' missing or partial postal address'