You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "M4n5ter (via GitHub)" <gi...@apache.org> on 2026/09/05 15:25:32 UTC
[PR] fix(desktop): avoid Owner-only IPC requests from shared Session guests [maka]
M4n5ter opened a new pull request, #4858:
URL: https://github.com/apache/maka/pull/4858
<details open>
<summary>English</summary>
## Fix
Shared Session guests were included in Owner-only onboarding and workspace-search requests. Because those handlers are never registered for Guests, each request waited through the 15-second reconnection window, producing repeated errors and delaying aggregate results. The transcript also requested Owner-only turn landmarks for shared Sessions.
- Query only ready Owner hosts for onboarding aggregation and workspace search. Keep shared Sessions in the separate mount catalog.
- Request full-history turn landmarks only for Owner Sessions; preserve Guest transcript paging and navigation over loaded content.
- Record each connected target's registered IPC surface. Reject unsupported channels immediately while retaining bounded recovery for supported channels during disconnects. Preserve uncertain-control reconciliation without replaying mutations.
- Leave Guest grants and the wire protocol unchanged.
## Validation
- Desktop suite: 2,187 tests passed.
- Main/preload builds and preload/renderer TypeScript checks passed.
- Changed-file lint, app-shell hook checks, and ASF header checks passed.
- Regression coverage exercises the production preload bundle with concurrent Owner/Guest identities, Guest catalog retention, unsupported IPC, Owner reconnect, unavailable reconciliation, and late Owner landmark responses after switching to Guest.
- Windows-to-macOS live-device retest remains pending; automated validation ran under Linux/WSL.
AI assistance: OpenAI Codex.
</details>
<details>
<summary>中文</summary>
## 修复
共享会话 Guest 被错误纳入了仅限 Owner 的 onboarding 和工作区搜索请求。这些接口从未在 Guest 上注册,每次调用却会等待 15 秒重连窗口,造成反复报错及聚合结果延迟。历史导航也会对共享会话请求仅限 Owner 的完整导航标记。
- onboarding 聚合和工作区搜索仅请求已就绪的 Owner;共享会话仍通过独立挂载目录保留在列表中。
- 仅对 Owner 会话请求完整历史导航标记,保留 Guest 的历史分页和已加载内容导航。
- 记录已连接目标实际注册的 IPC 接口,立即拒绝不支持的调用;支持的接口断线后仍按原有有界窗口恢复,不重放结果未确认的写操作。
- 不扩大 Guest 权限,不修改通信协议。
## 验证
- Desktop 全量 2,187 项测试通过。
- main/preload 构建及 preload/renderer TypeScript 检查通过。
- 改动文件 lint、app-shell hook 和 ASF 许可证头检查通过。
- 回归测试覆盖真实 preload bundle 中 Owner/Guest 并存、共享目录保留、不支持的 IPC、Owner 重连、无法继续核对的写操作,以及切换 Guest 后迟到的 Owner 导航响应。
- 尚未完成 Windows→macOS 真机复测;自动验证在 Linux/WSL 下执行。
AI 辅助:OpenAI Codex。
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): avoid Owner-only IPC requests from shared Session guests [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #4858:
URL: https://github.com/apache/maka/pull/4858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): avoid Owner-only IPC requests from shared Session guests [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter commented on PR #4858:
URL: https://github.com/apache/maka/pull/4858#issuecomment-5553028796
<details open>
<summary>English</summary>
Addressed in `08cf52906`. Disposition of the review on `d8303a934`:
- **P2, Guest as default Host — not accepted.** Guest access is [rejected by profile admission](https://github.com/apache/maka/blob/08cf52906/apps/desktop/src/main/runtime-host-profile-service.ts#L727) and retained as a separate Session mount. Startup [removes legacy Guest profiles and normalizes the default](https://github.com/apache/maka/blob/08cf52906/apps/desktop/src/main/runtime-host-profile-service.ts#L223). The [default-selection entry requires an enabled profile](https://github.com/apache/maka/blob/08cf52906/apps/desktop/src/main/runtime-host-profile-service.ts#L1297). There is no supported Guest-default path requiring an onboarding fallback. Also, failure of the primary onboarding request already threw before this PR; it was not a partial-results fallback.
- **P3, late registration — the stated permanent rejection is not current behavior:** a live handler takes precedence over the support lookup. No production lazy-registration path was identified. As part of the lifecycle correction below, completion now seals the individual candidate's registration record; late additions explicitly fail, while a replacement candidate can register normally.
- **P3, support lost on reconnect — not accepted.** [Ordinary reconnect publishes readiness changes within the same active epoch](https://github.com/apache/maka/blob/08cf52906/apps/desktop/src/main/runtime-host-desktop-manager.ts#L1351); it does not call `deactivate`. Known support is retained throughout that gap.
**Confirmed and fixed:** EOF immediately after the final initialization response could tear down live handlers before the manager took its support snapshot. The base recovered the pending Owner read; the previous PR head incorrectly returned `RuntimeHostHandlerUnsupportedError`. Support now comes from the candidate-owned registration history, independently of handler cleanup. A regression using real candidates verifies recovery through a replacement.
Validation: 2,188 Desktop tests passed, including the new startup-close regression; main build, preload/renderer type checks, changed-file lint, and ASF header checks passed. Live Windows-to-macOS retest remains pending.
AI assistance: OpenAI Codex.
</details>
<details>
<summary>中文</summary>
已更新至 `08cf52906`。
- Guest 默认 Host:不采纳。Guest 被 profile 接入规则拒绝、只保留为独立会话挂载;启动时清理旧 Guest profile 并归一化默认项,切换默认项也要求已启用的 profile。主 onboarding 失败在原代码中就会抛错,并非本 PR 新增的行为。
- 晚注册永久拒绝:原结论不成立,存在的 handler 优先于支持表检查。此次根因修复同时将 candidate 注册记录封存,明确拒绝完成后的追加注册;替代 candidate 仍可正常注册。
- 正常重连清空支持表:不成立。重连保留同一活跃 epoch,不调用 deactivate。
- 确认并修复了初始化末尾 EOF 的竞态:接口支持信息改为来自 candidate 自身的注册记录,不再从可能已经被清理的活跃 handler 反推。真实 candidate 回归测试验证请求可以等到替代连接恢复。
Desktop 全量 2,188 项测试及上述静态检查通过;Windows→macOS 真机复测仍待完成。
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org