You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "xiong duan (Jira)" <ji...@apache.org> on 2024/05/24 10:39:00 UTC

[jira] [Commented] (CALCITE-6416) Remove unnecessary SUBSTRING rewrite in SparkSqlDialect

    [ https://issues.apache.org/jira/browse/CALCITE-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849254#comment-17849254 ] 

xiong duan commented on CALCITE-6416:
-------------------------------------

Fixed in [{{4def070}}|https://github.com/apache/calcite/commit/4def07066b6cb370e37739985b19f6e6b408addb]. Thanks for the review [~mbudiu]. 

> Remove unnecessary SUBSTRING rewrite in SparkSqlDialect
> -------------------------------------------------------
>
>                 Key: CALCITE-6416
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6416
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.37.0
>            Reporter: xiong duan
>            Assignee: xiong duan
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.38.0
>
>
> SparkSqlDialect have a unnecessary rewrite about SUBSTRING func.
> In CALCITE-3247, We handle the SUBSTRING rewrite in HiveSqlDialect.
> In CALCITE-3072, We handle the SUBSTRING rewrite in SparkSqlDialect.
> In CALCITE-5677, We refactor the SUBSTRING as the default behaviour and remove the SUBSTRING rewrite in HiveSqlDialect. This PR will remove the Spark.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)