You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/03/08 11:48:00 UTC
[GitHub] [tomcat] dagnelies opened a new pull request #412: Adding default manager roles in tomcat users config.
dagnelies opened a new pull request #412:
URL: https://github.com/apache/tomcat/pull/412
Every time I install a tomcat, I first add the tomcat manager users, and I think a lot of people do this as well. However, currently, it's kind of a pain because you have to look it up first what exactly should be written and create the roles/users manually. This here makes it trivial.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] dagnelies edited a comment on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
dagnelies edited a comment on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817654873
@kkolinko Regarding:
> There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are created automatically.
I wasn't aware of that. If roles are automatically generated, what's the use of the `role` tag at all? I just assumed it was required since it's present in all examples.
I'll remove the JMX part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-797017293
> For some reason `getParentStream()` returns null on s390x (JDK11).
>
> https://github.com/apache/tomcat/blob/efe0fe8b3d6b10b7e416c32b59f60bb441831c39/java/org/apache/coyote/http2/AbstractNonZeroStream.java#L125
🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] kkolinko commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
kkolinko commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817721078
>
>
> @kkolinko Regarding:
>
> > There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are created automatically.
>
> I wasn't aware of that. If roles are automatically generated, what's the use of the `role` tag at all? I just assumed it was required since it's present in all examples.
- If you need to declare a role that has no users assigned to it, the role can be declared with a "role" element. Such use case is rare (e.g. if users are managed via some GUI and you want to be able to list all available roles).
- When a user database is saved (written out), "role" elements are written as well, for completeness. This operation can be triggered via JMX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-795354818
For some reason `getParentStream()` returns null on s390x (JDK11).
https://github.com/apache/tomcat/blob/efe0fe8b3d6b10b7e416c32b59f60bb441831c39/java/org/apache/coyote/http2/AbstractNonZeroStream.java#L125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] kkolinko edited a comment on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
kkolinko edited a comment on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817630063
` <user username="admin" password="<must-be-changed>" roles="manager-gui,manager-jmx"/>
`
-1 for the above line. The "manager-jmx" role is not intended to be used by human users: it does not have CSRF protection.
See
https://tomcat.apache.org/tomcat-9.0-doc/manager-howto.html#Configuring_Manager_Application_Access
` <role rolename="manager-gui"/> etc.
`
There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are created automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] kkolinko commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
kkolinko commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817630063
> <user username="admin" password="<must-be-changed>" roles="manager-gui,manager-jmx"/>
-1 for the above line. The "manager-jmx" role is not intended to be used by human users: it does not have CSRF protection.
See
https://tomcat.apache.org/tomcat-9.0-doc/manager-howto.html#Configuring_Manager_Application_Access
> <role rolename="manager-gui"/> etc.
There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are created automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] dagnelies commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
dagnelies commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817606698
Hi, since the Travis CI possibly failed due to some unrelated instability, can we perhaps simply try to re-run it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] dagnelies commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
dagnelies commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-795327884
...I guess the travis CI is currently broken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817610088
> can we perhaps simply try to re-run it?
Re-scheduled it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #412:
URL: https://github.com/apache/tomcat/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] dagnelies commented on pull request #412: Adding default manager roles in tomcat users config.
Posted by GitBox <gi...@apache.org>.
dagnelies commented on pull request #412:
URL: https://github.com/apache/tomcat/pull/412#issuecomment-817654873
@kkolinko Regarding:
> There rarely is a need to explicitly create roles like the above. When parsing the tomcat-users.xml file, all roles mentioned in users are created automatically.
I wasn't aware of that. If roles are automatically generated, what's the use of the annotation at all? I just assumed it was required since it's present in all examples.
I'll remove the JMX part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org