You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/01/02 20:52:57 UTC
Re: Review Request 29121: NetworkIsolatorFilter: Make error message
explicit instead of skipping sliently.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29121/#review66546
-----------------------------------------------------------
src/tests/environment.cpp
<https://reviews.apache.org/r/29121/#comment110118>
Does it mean we should just disable any test with MultipleSlaves (return true)?
- Timothy Chen
On Dec. 16, 2014, 10:14 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29121/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 10:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> NetworkIsolatorFilter: Make error message explicit instead of skipping sliently.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp bc2fc90fe956ac3c075cb7c850eb9481820380fd
>
> Diff: https://reviews.apache.org/r/29121/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 29121: NetworkIsolatorFilter: Make error message
explicit instead of skipping sliently.
Posted by Chi Zhang <ch...@gmail.com>.
> On Jan. 2, 2015, 7:52 p.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 241
> > <https://reviews.apache.org/r/29121/diff/1/?file=793313#file793313line241>
> >
> > Does it mean we should just disable any test with MultipleSlaves (return true)?
You are right. I was thinking if --with-network-isolator is used by system does not meet requirement, we can still proceed with the 'MultipleSlaves' test. Upon a 2nd look, the code path over there will return error, so it doesn't matter what is done here. Returning a true is probably more staightforward.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29121/#review66546
-----------------------------------------------------------
On Dec. 16, 2014, 10:14 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29121/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 10:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> NetworkIsolatorFilter: Make error message explicit instead of skipping sliently.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp bc2fc90fe956ac3c075cb7c850eb9481820380fd
>
> Diff: https://reviews.apache.org/r/29121/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>