You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/08/23 04:23:16 UTC

hbase git commit: HBASE-18467 just call the groovy implementation directly.

Repository: hbase
Updated Branches:
  refs/heads/HBASE-18467 be8c7a974 -> 7fd820063


HBASE-18467 just call the groovy implementation directly.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/7fd82006
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/7fd82006
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/7fd82006

Branch: refs/heads/HBASE-18467
Commit: 7fd820063982639f19a315fb569fd88d5a646de2
Parents: be8c7a9
Author: Sean Busbey <bu...@apache.org>
Authored: Tue Aug 22 22:56:43 2017 -0500
Committer: Sean Busbey <bu...@apache.org>
Committed: Tue Aug 22 22:56:43 2017 -0500

----------------------------------------------------------------------
 dev-support/Jenkinsfile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/7fd82006/dev-support/Jenkinsfile
----------------------------------------------------------------------
diff --git a/dev-support/Jenkinsfile b/dev-support/Jenkinsfile
index fb896ad..ec868b2 100644
--- a/dev-support/Jenkinsfile
+++ b/dev-support/Jenkinsfile
@@ -394,7 +394,6 @@ END
            echo ""
            echo "[INFO] There are ${currentBuild.changeSets.size()} change sets."
            def seenJiras = []
-           def jiraPattern = java.util.regex.Pattern.compile(/HBASE-[0-9]+/)
            for ( changelist in currentBuild.changeSets ) {
              if ( changelist.isEmptySet() ) {
                echo "[DEBUG] change set was empty, skipping JIRA comments."
@@ -410,7 +409,8 @@ END
                echo "     ${change.author}"
                echo ""
                // For now, only match the first occurrance of an HBase jira id, due to JENKINS-46358
-               msg.find( jiraPattern ) { currentIssue ->
+               currentIssue = org.codehaus.groovy.runtime.StringGroovyMethods.find(msg, /HBASE-[0-9]+/)
+               if (currentIssue != null ) {
                  echo "[DEBUG] found jira key: ${currentIssue}"
                  if ( currentIssue in seenJiras ) {
                    echo "[DEBUG] already commented on ${currentIssue}."
@@ -419,8 +419,9 @@ END
                    jiraComment issueKey: currentIssue, body: comment
                    seenJiras << currentIssue
                  }
+               } else {
+                  echo "[WARN] no JIRA key found in message, TODO email committer"
                }
-               //TODO warn if no JIRA key found in message, email committer
              }
            }
         } catch (Exception exception) {