You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2023/01/06 22:10:47 UTC

[GitHub] [echarts] piwatkins opened a new issue, #18146: [Bug]

piwatkins opened a new issue, #18146:
URL: https://github.com/apache/echarts/issues/18146

   ### Version
   
   3.53.1
   
   ### Link to Minimal Reproduction
   
   _No response_
   
   ### Steps to Reproduce
   
   I'm unable to recreate the error in JSFiddle.
   
   This happens when I have a pie chart with label: {position: "inside"} and minShowLabelAngle is set low enough that an small-angle item gets left out.
   
   
   
   
   ### Current Behavior
   
   Error stack:
   
   labelLayout.js:357 
           
          Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'states')
       at SeriesData.<anonymous> (labelLayout.js:357:22)
       at DataStore.each (DataStore.js:1009:11)
       at SeriesData.each (SeriesData.js:756:17)
       at pieLabelLayout (labelLayout.js:336:8)
       at PieView.render (PieView.js:291:5)
       at Task.progress (Chart.js:233:20)
       at Task._doProgress (task.js:187:10)
       at Task.perform (task.js:153:16)
       at echarts.js:1825:24
       at GlobalModel.<anonymous> (Global.js:654:10)
   
   pie/labelLayout.js is getting labelLine:
   
   var labelLine = sector.getTextGuideLine();
   
   and that's returning undefined, then it's trying to read from it:
   
      if (Math.abs(sectorShape.endAngle - sectorShape.startAngle) < minShowLabelRadian) {
         each(label.states, setNotShow);
         each(labelLine.states, setNotShow);  // THIS ERRORS
         label.ignore = labelLine.ignore = true;
         return;
       }
   
   ### Expected Behavior
   
   No javascript errors
   
   ### Environment
   
   ```markdown
   - OS: Windows 10
   - Browser: Edge 108.0.1462.54
   - Framework: Svelte 3.53.1, Echarts 5.40
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] closed issue #18146: [Bug]

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] closed issue #18146: [Bug] 
URL: https://github.com/apache/echarts/issues/18146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #18146: [Bug] Cannot read properties of undefined (reading 'states') in pie/labelLayout.js when minShowLabelAngle removes a small angle and label position is "inside"

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #18146:
URL: https://github.com/apache/echarts/issues/18146#issuecomment-1374429945

   5.4.1 has fixed this bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #18146: [Bug]

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #18146:
URL: https://github.com/apache/echarts/issues/18146#issuecomment-1374193324

   I'm sorry to close this issue for it lacks the necessary title. Please provide **a _descriptive_ and as _concise_ as possible title to describe your problems or requests** and then the maintainers or I will reopen this issue.
   
   Every good bug report or feature request starts with a title. Your issue title is a critical element as it's the first thing maintainers see.
   
   A good issue title makes it easier for maintainers to understand what the issue is, easily locate it, and know what steps they'll need to take to fix it.
   
   Moreover, it's better to include keywords, as this makes it easier to find the issue self and similar issues in searches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart closed issue #18146: [Bug] Cannot read properties of undefined (reading 'states') in pie/labelLayout.js when minShowLabelAngle removes a small angle and label position is "inside"

Posted by GitBox <gi...@apache.org>.
plainheart closed issue #18146: [Bug] Cannot read properties of undefined (reading 'states') in pie/labelLayout.js when minShowLabelAngle removes a small angle and label position is "inside"
URL: https://github.com/apache/echarts/issues/18146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org