You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/07/02 14:48:51 UTC

Re: [Issue 774] Changed - [PATCH] Early exit when acting on some non-versioned files

epg via issues@subversion.tigris.org writes:
>   Created an attachment (id=25)
>   patch

Thanks for the patch, Eric!

Hey committers: can anyone spare some cycles to review and apply this?

My brain is deep into Marcus Comstedt's patch right now; Ben C-S and
Mike Pilato are also engaged at the moment, so it might be a few days
before anyone in the Chicago office could take care of this.  I'd
rather the patch not get a chance to go stale...

> + --- Additional Comments From epg@tigris.org  2002-07-01 21:08 PDT ---
> + I forgot to mention a decision i made.  I decided not to let these
> + warnings affect the exit code of the process.  My only reason is that
> + that's what cvs does :).  I don't think there's any other sane
> + behavior available, since we can have multiple failures (at least two
> + are treated different internally: a non-versioned file gets triggers
> + one code, and a non-versioned directory triggers another ("not a
> + working copy", or something; i don't exactly remember)).  Which would
> + we report?

That seems like a good decision to me.  (Can anyone think of a better
solution?)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org