You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "GrumpyCat51 (via GitHub)" <gi...@apache.org> on 2025/09/25 14:56:53 UTC
[PR] [helm] Add terminationGracePeriodSeconds to api server deployment [airflow]
GrumpyCat51 opened a new pull request, #56096:
URL: https://github.com/apache/airflow/pull/56096
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This MR adds the `terminationGracePeriodSeconds` setting to the api server deployment similar to the other deployments.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [helm] Add terminationGracePeriodSeconds to api server deployment [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on code in PR #56096:
URL: https://github.com/apache/airflow/pull/56096#discussion_r2401159095
##########
chart/values.yaml:
##########
@@ -1422,6 +1422,10 @@ apiServer:
args: ["bash", "-c", "exec airflow api-server"]
allowPodLogReading: true
env: []
+
+ # Grace period for Airflow API server to finish after SIGTERM is sent from kubernetes
Review Comment:
```suggestion
# Grace period for API server to finish after SIGTERM is sent from kubernetes
```
##########
chart/values.schema.json:
##########
@@ -5094,6 +5094,11 @@
],
"default": null
},
+ "terminationGracePeriodSeconds": {
+ "description": "Grace period for Airflow API server to finish after SIGTERM is sent from Kubernetes.",
Review Comment:
```suggestion
"description": "Grace period for API server to finish after SIGTERM is sent from Kubernetes.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [helm] Add terminationGracePeriodSeconds to api server deployment [airflow]
Posted by "HsiuChuanHsu (via GitHub)" <gi...@apache.org>.
HsiuChuanHsu commented on PR #56096:
URL: https://github.com/apache/airflow/pull/56096#issuecomment-3336436983
Nice work!
We should also include the `terminationGracePeriodSeconds` definition in `/chart/values.schema.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [helm] Add terminationGracePeriodSeconds to api server deployment [airflow]
Posted by "GrumpyCat51 (via GitHub)" <gi...@apache.org>.
GrumpyCat51 commented on PR #56096:
URL: https://github.com/apache/airflow/pull/56096#issuecomment-3336990767
> Nice work! We should also include the `terminationGracePeriodSeconds` definition in `/chart/values.schema.json`.
indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [helm] Add terminationGracePeriodSeconds to api server deployment [airflow]
Posted by "GrumpyCat51 (via GitHub)" <gi...@apache.org>.
GrumpyCat51 closed pull request #56096: [helm] Add terminationGracePeriodSeconds to api server deployment
URL: https://github.com/apache/airflow/pull/56096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org