You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (Jira)" <ji...@apache.org> on 2020/06/23 18:25:00 UTC
[jira] [Commented] (MNG-6944)
881274914a80946f8af6e435eff064d3c89974fa introduces regression
[ https://issues.apache.org/jira/browse/MNG-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143186#comment-17143186 ]
Robert Scholte commented on MNG-6944:
-------------------------------------
I think it has always been a problem, but now it is covered by a unittest. The root cause is that since Java 10(?) the order of Map entries are not predicatable anymore. And that exposed an issue in the comparator, which I will fix.
This also shows another issue. We're running unittests only with Java 8, but ITs with the whole range. Makes we wonder if we should go for Java 8 and LATEST for unittests.
> 881274914a80946f8af6e435eff064d3c89974fa introduces regression
> --------------------------------------------------------------
>
> Key: MNG-6944
> URL: https://issues.apache.org/jira/browse/MNG-6944
> Project: Maven
> Issue Type: Bug
> Components: core
> Affects Versions: 3.7.0
> Reporter: Michael Osipov
> Assignee: Robert Scholte
> Priority: Blocker
>
> When tests are run on OpenJDK 11+:
> {noformat}
> $ mvn -v
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
> Maven home: /usr/local/apache-maven-3.5.4
> Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/local/openjdk11
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "freebsd", version: "12.1-stable", arch: "amd64", family: "unix"
> {noformat}
> I see the following failure:
> {noformat}
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] DefaultLifecyclesTest.testCustomLifecycle:116
> Expected: is "clean"
> but: was "site"
> [INFO]
> [ERROR] Tests run: 359, Failures: 1, Errors: 0, Skipped: 1
> {noformat}
> {{git bisect}} points to:
> {noformat}
> $ git bisect bad
> 881274914a80946f8af6e435eff064d3c89974fa is the first bad commit
> commit 881274914a80946f8af6e435eff064d3c89974fa
> Author: rfscholte <rf...@apache.org>
> Date: Mon Jun 22 20:26:56 2020 +0200
> [MNG-6917] Introduce wrapper lifecycle
> .../apache/maven/lifecycle/DefaultLifecycles.java | 83 ++++++++++----------
> .../main/resources/META-INF/plexus/components.xml | 20 +++++
> .../maven/lifecycle/DefaultLifecyclesTest.java | 90 ++++++++++++++++++----
> .../maven/lifecycle/LifecycleExecutorTest.java | 14 ++--
> .../internal/stub/DefaultLifecyclesStub.java | 4 +-
> .../stub/LifecycleExecutionPlanCalculatorStub.java | 4 +
> 6 files changed, 153 insertions(+), 62 deletions(-)
> {noformat}
> It does not fail with:
> {noformat}
> $ mvn -v
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
> Maven home: /usr/local/apache-maven-3.5.4
> Java version: 1.8.0_252, vendor: The FreeBSD Project, runtime: /usr/local/openjdk8/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "freebsd", version: "12.1-stable", arch: "amd64", family: "unix"
> {noformat}
> and fails also with:
> {noformat}
> $ ~/apache-maven-3.6.3/bin/mvn -v clean verify -Drat.skip
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /net/home/osipovmi/apache-maven-3.6.3
> Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/local/openjdk11
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "freebsd", version: "12.1-stable", arch: "amd64", family: "unix"
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)