You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "gmiklos-ltg (via GitHub)" <gi...@apache.org> on 2023/04/17 09:10:17 UTC
[GitHub] [pulsar] gmiklos-ltg opened a new pull request, #20114: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20. (targeted for master)
gmiklos-ltg opened a new pull request, #20114:
URL: https://github.com/apache/pulsar/pull/20114
Fixes #20088
### Motivation
While evaluating Pulsar Functions for our data transformation purposes we ran into an issue where the Kotlin runtime of the function clashed with the runtime provided by Pulsar which is a bit outdated (1.4.32).
### Modifications
Upgraded Kotlin to 1.8.20 in the root pom.xml.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [x] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: (https://github.com/gmiklos-ltg/pulsar/pull/4)
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20114: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20. (targeted for master)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20114:
URL: https://github.com/apache/pulsar/pull/20114#issuecomment-1512640337
@gmiklos-ltg Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20114: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20. (targeted for master)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20114:
URL: https://github.com/apache/pulsar/pull/20114#issuecomment-1512739933
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20114: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20. (targeted for master)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20114:
URL: https://github.com/apache/pulsar/pull/20114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20114: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20. (targeted for master)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20114:
URL: https://github.com/apache/pulsar/pull/20114#issuecomment-1512721232
## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20114](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7fa6b9) into [master](https://codecov.io/gh/apache/pulsar/commit/c4aec6661e795c46181dc1fa79282065fa875768?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4aec66) will **increase** coverage by `39.77%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #20114 +/- ##
=============================================
+ Coverage 33.16% 72.93% +39.77%
+ Complexity 12225 3695 -8530
=============================================
Files 1499 1868 +369
Lines 114340 138318 +23978
Branches 12415 15214 +2799
=============================================
+ Hits 37918 100883 +62965
+ Misses 71484 29423 -42061
- Partials 4938 8012 +3074
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.17% <0.00%> (?)` | |
| systests | `24.94% <0.00%> (?)` | |
| unittests | `72.21% <40.00%> (+39.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...unctions/runtime/kubernetes/KubernetesRuntime.java](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy9ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvZnVuY3Rpb25zL3J1bnRpbWUva3ViZXJuZXRlcy9LdWJlcm5ldGVzUnVudGltZS5qYXZh) | `38.27% <0.00%> (+38.27%)` | :arrow_up: |
| [...tions/auth/KubernetesSecretsTokenAuthProvider.java](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy9ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvZnVuY3Rpb25zL2F1dGgvS3ViZXJuZXRlc1NlY3JldHNUb2tlbkF1dGhQcm92aWRlci5qYXZh) | `44.60% <50.00%> (+44.60%)` | :arrow_up: |
| [...s/runtime/kubernetes/KubernetesRuntimeFactory.java](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy9ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvZnVuY3Rpb25zL3J1bnRpbWUva3ViZXJuZXRlcy9LdWJlcm5ldGVzUnVudGltZUZhY3RvcnkuamF2YQ==) | `80.42% <100.00%> (+80.42%)` | :arrow_up: |
| [...e/pulsar/io/elasticsearch/ElasticSearchConfig.java](https://codecov.io/gh/apache/pulsar/pull/20114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2VsYXN0aWMtc2VhcmNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvaW8vZWxhc3RpY3NlYXJjaC9FbGFzdGljU2VhcmNoQ29uZmlnLmphdmE=) | `90.67% <100.00%> (ø)` | |
... and [1538 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/20114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org