[jira] [Work logged] (BEAM-7945) Allow runner to configure "semi_persist_dir" which is used in the SDK harness

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-7945?focusedWorklogId=415099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415099 ]

ASF GitHub Bot logged work on BEAM-7945:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Apr/20 22:40
            Start Date: 02/Apr/20 22:40
    Worklog Time Spent: 10m 
      Work Description: ibzib commented on pull request #9452: [BEAM-7945] Allow runner to configure semi_persist_dir which is used …
URL: https://github.com/apache/beam/pull/9452#discussion_r402637170
 
 

 ##########
 File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
 ##########
 @@ -132,20 +133,30 @@ public RemoteEnvironment createEnvironment(Environment environment) throws Excep
             // host networking on Mac)
             .add("--env=DOCKER_MAC_CONTAINER=" + System.getenv("DOCKER_MAC_CONTAINER"));
 
-    List<String> args =
-        ImmutableList.of(
-            String.format("--id=%s", workerId),
-            String.format("--logging_endpoint=%s", loggingEndpoint),
-            String.format("--artifact_endpoint=%s", artifactEndpoint),
-            String.format("--provision_endpoint=%s", provisionEndpoint),
-            String.format("--control_endpoint=%s", controlEndpoint));
+    Boolean retainDockerContainer =
+        pipelineOptions.as(ManualDockerEnvironmentOptions.class).getRetainDockerContainers();
+    if (!retainDockerContainer) {
+      dockerOptsBuilder.add("--rm");
 
 Review comment:
   Why was this added in this PR? It seems orthogonal to `semi_persist_dir`. I believe this is a regression; perhaps a rebasing error?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 415099)
    Time Spent: 4h 20m  (was: 4h 10m)

> Allow runner to configure "semi_persist_dir" which is used in the SDK harness
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-7945
>                 URL: https://issues.apache.org/jira/browse/BEAM-7945
>             Project: Beam
>          Issue Type: Sub-task
>          Components: java-fn-execution, sdk-go, sdk-java-core, sdk-py-core
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>             Fix For: 2.17.0
>
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Currently "semi_persist_dir" is not configurable. This may become a problem in certain scenarios. For example, the default value of "semi_persist_dir" is "/tmp" ([https://github.com/apache/beam/blob/master/sdks/python/container/boot.go#L48]) in Python SDK harness. When the environment type is "PROCESS", the disk of "/tmp" may be filled up and unexpected issues will occur in production environment. We should provide a way to configure "semi_persist_dir" in EnvironmentFactory at the runner side. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)