You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Adaverse (via GitHub)" <gi...@apache.org> on 2023/05/20 08:12:31 UTC
[GitHub] [airflow] Adaverse opened a new pull request, #31435: Added missing command to install the packages through YARN
Adaverse opened a new pull request, #31435:
URL: https://github.com/apache/airflow/pull/31435
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Adaverse commented on a diff in pull request #31435: Added missing command to install the packages through YARN
Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206031871
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the following command
Review Comment:
Something needs to be added to the doc. Even if I follow all of them, when I run the server and do `yarn run dev` and webserver in debug mode, the UI won't render the react components saying assets not found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #31435: Added missing command to install the packages through YARN
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206024833
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the following command
Review Comment:
I don't think this should be the 4th step of `To install yarn on macOS:`, this is not part of the yarn install process.
There is a section bellow to run the server in dev mode, maybe we could add that as the first step before the `yarn run dev` ?
```
# Starts a web server that manages and updates your assets as you modify them
# You'll need to run the webserver in debug mode too: ``airflow webserver -d``
yarn run dev
```
edit: It was like this before and is actually part of a bigger section [Installing yarn and its packages manually](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id55).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #31435: Added missing command to install the packages through YARN
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206024833
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the following command
Review Comment:
I don't think this should be the 4th step of `To install yarn on macOS:`, this is not part of the yarn install process.
There is a section bellow to run the server in dev mode, maybe we could add that as the first step before the `yarn run dev` ?
```
# Starts a web server that manages and updates your assets as you modify them
# You'll need to run the webserver in debug mode too: ``airflow webserver -d``
yarn run dev
```
edit: It was like this before and is actually part of a bigger section [Installing yarn and its packages manually](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id55). (still find it a bit confusing but non blocking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #31435: Added missing command to install the packages through YARN
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206024833
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the following command
Review Comment:
I don't think this should be the 4th step of `To install yarn on macOS:`, this is not part of the yarn install process.
There is a section bellow to run the server in dev mode, maybe we could add that as the first step before the `yarn run dev` ?
```
# Starts a web server that manages and updates your assets as you modify them
# You'll need to run the webserver in debug mode too: ``airflow webserver -d``
yarn run dev
```
edit: My bad, it was like this before and is part of a bigger section [Installing yarn and its packages manually](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id55). Fine by me then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #31435: Added missing command to install the packages through YARN
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206024833
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the following command
Review Comment:
I don't think this should be the 4th step of `To install yarn on macOS:`, this is not part of the yarn install process.
There is a section bellow to run the server in dev mode, maybe we could add that as the first step before the `yarn run dev` ?
```
# Starts a web server that manages and updates your assets as you modify them
# You'll need to run the webserver in debug mode too: ``airflow webserver -d``
yarn run dev
```
edit: My bad, it was like this before and is part of a bigger section [Installing yarn and its packages manually](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id55).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #31435: Added missing command to install the packages through YARN
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206024833
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the following command
Review Comment:
I don't think this should be the 4th step of `To install yarn on macOS:`, this is not part of the yarn install process.
There is a section bellow to run the server in dev mode, maybe we could add that as the first step before the `yarn run dev` ?
```
# Starts a web server that manages and updates your assets as you modify them
# You'll need to run the webserver in debug mode too: ``airflow webserver -d``
yarn run dev
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Adaverse commented on pull request #31435: Added missing command to install the packages through YARN
Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on PR #31435:
URL: https://github.com/apache/airflow/pull/31435#issuecomment-1562371491
@eladkal can it be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun merged pull request #31435: Added missing command to install the packages through YARN
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #31435:
URL: https://github.com/apache/airflow/pull/31435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org