You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/05/02 22:04:49 UTC
[GitHub] [helix] xyuanlu opened a new pull request, #2476: Fix/refactor TestRoutingTableProvider
xyuanlu opened a new pull request, #2476:
URL: https://github.com/apache/helix/pull/2476
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#2472
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a diff in pull request #2476: Fix/refactor TestRoutingTableProvider
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue commented on code in PR #2476:
URL: https://github.com/apache/helix/pull/2476#discussion_r1183096065
##########
helix-core/src/test/java/org/apache/helix/integration/spectator/TestRoutingTableProvider.java:
##########
@@ -82,7 +84,7 @@ public class TestRoutingTableProvider extends ZkTestBase {
private boolean _listenerTestResult = true;
- private static final AtomicBoolean customizedViewChangeCalled = new AtomicBoolean(false);
+ //private static final AtomicBoolean customizedViewChangeCalled = new AtomicBoolean(false);
Review Comment:
Remove this if this is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #2476: Refactor TestRoutingTableProvider
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on PR #2476:
URL: https://github.com/apache/helix/pull/2476#issuecomment-1538888826
This PR is ready to be merged. Approved by @junkaixue @parakhnr @desaikomal //Thanks!!
Commit message: Refactor TestRoutingTableProvider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] parakhnr commented on a diff in pull request #2476: Refactor TestRoutingTableProvider
Posted by "parakhnr (via GitHub)" <gi...@apache.org>.
parakhnr commented on code in PR #2476:
URL: https://github.com/apache/helix/pull/2476#discussion_r1183141335
##########
helix-core/src/test/java/org/apache/helix/integration/spectator/TestRoutingTableProvider.java:
##########
@@ -298,21 +284,26 @@ public void testCustomizedViewWithoutType() {
public void testCustomizedViewCorrectConstructor() throws Exception {
Map<PropertyType, List<String>> sourceDataTypes = new HashMap<>();
sourceDataTypes.put(PropertyType.CUSTOMIZEDVIEW, Arrays.asList("typeA"));
- MockRoutingTableProvider routingTableProvider =
- new MockRoutingTableProvider(_spectator, sourceDataTypes);
+ CountDownLatch countDownLatch = new CountDownLatch(1);
+ RoutingTableProvider routingTableProvider =
+ new RoutingTableProvider(_spectator, sourceDataTypes) {
+ @Override
+ public void onCustomizedViewChange(List<CustomizedView> customizedViewList,
+ NotificationContext changeContext){
+ countDownLatch.countDown();
+ super.onCustomizedViewChange(customizedViewList, changeContext);
+ }
+ };
CustomizedView customizedView = new CustomizedView(TEST_DB);
customizedView.setState("p1", "h1", "testState");
// Clear the flag before writing to the Customized View Path
- customizedViewChangeCalled.getAndSet(false);
String customizedViewPath = PropertyPathBuilder.customizedView(CLUSTER_NAME, "typeA", TEST_DB);
_spectator.getHelixDataAccessor().getBaseDataAccessor().set(customizedViewPath,
customizedView.getRecord(), AccessOption.PERSISTENT);
- boolean onCustomizedViewChangeCalled =
- TestHelper.verify(() -> customizedViewChangeCalled.get(), WAIT_DURATION);
- Assert.assertTrue(onCustomizedViewChangeCalled);
+ Assert.assertTrue(countDownLatch.await(5000, TimeUnit.MILLISECONDS));
Review Comment:
nit: Should we use `WAIT_DURATION` instead of `5000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2476: Refactor TestRoutingTableProvider
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2476:
URL: https://github.com/apache/helix/pull/2476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2476: Fix/refactor TestRoutingTableProvider
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on code in PR #2476:
URL: https://github.com/apache/helix/pull/2476#discussion_r1183129923
##########
helix-core/src/test/java/org/apache/helix/integration/spectator/TestRoutingTableProvider.java:
##########
@@ -82,7 +84,7 @@ public class TestRoutingTableProvider extends ZkTestBase {
private boolean _listenerTestResult = true;
- private static final AtomicBoolean customizedViewChangeCalled = new AtomicBoolean(false);
+ //private static final AtomicBoolean customizedViewChangeCalled = new AtomicBoolean(false);
Review Comment:
TFTR. updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org