You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/29 21:22:38 UTC
[GitHub] [tvm] areusch opened a new pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
areusch opened a new pull request #7769:
URL: https://github.com/apache/tvm/pull/7769
* Remove __pycache__ directories only underneath checked-in
subdirectories to hopefully avoid long find runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#discussion_r606043432
##########
File path: tests/scripts/task_python_microtvm.sh
##########
@@ -22,8 +22,12 @@ set -x # NOTE(areusch): Adding to diagnose flaky timeouts
source tests/scripts/setup-pytest-env.sh
-# cleanup pycache
-find . -type f -path "*.pyc" | xargs rm -f
+# Search for __pycache__ in all checked-in dirs. As of now, no Python code is
Review comment:
I was pretty sure there was some issue with running this locally, but I now can't remember what it was. what isn't commented, isn't. let's try running through CI at least, worst case we have exactly the logic we need to bring back in the first patch on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kimmjinhong removed a comment on pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
kimmjinhong removed a comment on pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#issuecomment-809882910
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kimmjinhong commented on pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
kimmjinhong commented on pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#issuecomment-809882910
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #7769:
URL: https://github.com/apache/tvm/pull/7769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#issuecomment-810221143
will let @jroesch manage the PR. I agree perhaps it is good oractice overall to first detect pycache and then pyc, perhaps move it to a test/scrippt auxiliary script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#issuecomment-813712170
@jroesch let's merge this--it just removes the code. if we need it back, we can bring it back from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#issuecomment-809817049
@tqchen @jroesch thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on a change in pull request #7769: [µTVM] Try to fix qemu hangs in the CI #7590
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #7769:
URL: https://github.com/apache/tvm/pull/7769#discussion_r605322366
##########
File path: tests/scripts/task_python_microtvm.sh
##########
@@ -22,8 +22,12 @@ set -x # NOTE(areusch): Adding to diagnose flaky timeouts
source tests/scripts/setup-pytest-env.sh
-# cleanup pycache
-find . -type f -path "*.pyc" | xargs rm -f
+# Search for __pycache__ in all checked-in dirs. As of now, no Python code is
Review comment:
Do we want to put this in just uTVM? isn't pycache potentially a problem for us everywhere? also isn't the python interpreter in theory suppose to handle this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org