[GitHub] [hbase] virajjasani commented on pull request #3857: HBASE-26458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting

[GitBox <gi...@apache.org>]

virajjasani commented on pull request #3857:
URL: https://github.com/apache/hbase/pull/3857#issuecomment-973916353


   @joswiatek I think here also we will have to follow the same approach as branch-2/master by converting -1 to 0 because proto already has 0 as default value of TTL that we don't want to change:
   
   ```
   /**
    * Description of the snapshot to take
    */
   message SnapshotDescription {
     required string name = 1;
     optional string table = 2; // not needed for delete, but checked for in taking snapshot
     optional int64 creation_time = 3 [default = 0];
     enum Type {
       DISABLED = 0;
       FLUSH = 1;
       SKIPFLUSH = 2;
     }
     optional Type type = 4 [default = FLUSH];
     optional int32 version = 5;
     optional string owner = 6;
     optional UsersAndPermissions users_and_permissions = 7;
     optional int64 ttl = 8 [default = 0];
   }
   ```
   
   And the reason for converting to 0 from client side remains same as we discussed: server RPC payload itself has 0 as default (non-specified) value, hence server side should handle 0 as not specified TTL rather than -1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org