You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/26 04:21:33 UTC
[GitHub] [flink] dianfu opened a new pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
dianfu opened a new pull request #14755:
URL: https://github.com/apache/flink/pull/14755
## What is the purpose of the change
*Not all zip files are importable in Python and so we should expand zip file dependencies and add the root directory to PYTHONPATH. This pull request extracts zip file dependencies before adding to PYTHONPATH.*
## Brief change log
- *Update PythonEnvUtils to fix the client side*
- *Update ProcessPythonEnvironmentManager to fix the server side*
## Verifying this change
This change added tests and can be verified as follows:
- *Updated PythonEnvUtilsTest and ProcessPythonEnvironmentManagerTest*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
}, {
"hash" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496",
"triggerID" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"triggerType" : "PUSH"
}, {
"hash" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eacd669b14e1be1dee5d589016318b51e5bdd56e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494)
* 0eb2a54315aab1058d59918ce625391dda994b6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496)
* 3f9f835376f1e81b438983af9ce3e263991543aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eacd669b14e1be1dee5d589016318b51e5bdd56e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
}, {
"hash" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eacd669b14e1be1dee5d589016318b51e5bdd56e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494)
* 0eb2a54315aab1058d59918ce625391dda994b6a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767280247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767280247
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3f9f835376f1e81b438983af9ce3e263991543aa (Fri May 28 08:07:23 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767340342
@WeiZhong94 Thanks a lot for the review. Updated the PR~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
}, {
"hash" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496",
"triggerID" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eacd669b14e1be1dee5d589016318b51e5bdd56e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494)
* 0eb2a54315aab1058d59918ce625391dda994b6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
}, {
"hash" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496",
"triggerID" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"triggerType" : "PUSH"
}, {
"hash" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12499",
"triggerID" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f9f835376f1e81b438983af9ce3e263991543aa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12499)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WeiZhong94 commented on a change in pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on a change in pull request #14755:
URL: https://github.com/apache/flink/pull/14755#discussion_r564277842
##########
File path: flink-python/src/test/java/org/apache/flink/client/python/PythonEnvUtilsTest.java
##########
@@ -76,10 +79,16 @@ public void testPreparePythonEnvironment() throws IOException {
File relativeFile =
new File(tmpDirPath + File.separator + "subdir" + File.separator + "b.py");
File schemeFile =
- new File(tmpDirPath + File.separator + "subdir" + File.separator + "c.zip");
+ new File(tmpDirPath + File.separator + "subdir" + File.separator + "c.py");
Review comment:
We can rename the "c.zip" to "c.egg" so that its expected python path would not be the same as "b.py".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #14755:
URL: https://github.com/apache/flink/pull/14755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
}, {
"hash" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496",
"triggerID" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"triggerType" : "PUSH"
}, {
"hash" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12499",
"triggerID" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eacd669b14e1be1dee5d589016318b51e5bdd56e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494)
* 0eb2a54315aab1058d59918ce625391dda994b6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496)
* 3f9f835376f1e81b438983af9ce3e263991543aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12499)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
}, {
"hash" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496",
"triggerID" : "0eb2a54315aab1058d59918ce625391dda994b6a",
"triggerType" : "PUSH"
}, {
"hash" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12499",
"triggerID" : "3f9f835376f1e81b438983af9ce3e263991543aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0eb2a54315aab1058d59918ce625391dda994b6a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12496)
* 3f9f835376f1e81b438983af9ce3e263991543aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12499)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14755: [FLINK-21140][python] Extract zip file dependencies before adding to PYTHONPATH
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14755:
URL: https://github.com/apache/flink/pull/14755#issuecomment-767282148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494",
"triggerID" : "eacd669b14e1be1dee5d589016318b51e5bdd56e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eacd669b14e1be1dee5d589016318b51e5bdd56e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org