You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Gabriel Cosentino de Barros <gb...@yahoo-inc.com> on 2009/06/02 01:52:53 UTC

xml error's error on php version

Got the following error using the subversion checkout made now:
Fatal error: Call to undefined function parseXmlError()
in /var/www/shindig-svn/php/src/common/XmlError.php on line 35

Think it was an error on this commit
http://mail-archives.apache.org/mod_mbox/incubator-shindig-commits/200905.mbox/%3C20090510174450.DCEC223889D0@eris.apache.org%3E

the author probably had a more complex xml parser installed that
provided that missing global function. My install has the minimum
requirements shown on the site and also, that same commit provides that
funcionality by the next method, so I believe this is the intended
behaviour:

Index: php/src/common/XmlError.php
===================================================================
--- php/src/common/XmlError.php (revision 780868)
+++ php/src/common/XmlError.php (working copy)
@@ -32,7 +32,7 @@
       $xml = explode("\n", $xml);
     }
     foreach ($errors as $error) {
-      $ret .= parseXmlError($error, $xml);
+      $ret .= XmlError::display_xml_error($error, $xml);
     }
     libxml_clear_errors();
     return $ret;

cheers,
--gbarros

Re: xml error's error on php version

Posted by Chris Chabot <ch...@google.com>.
Hey gbarros,

I've gone and renamed the function to parseXmlError instead, so that the
call becomes self::parseXmlError; Which is consistent with our naming
conventions.

Thanks for the report!

   -- Chris

On Tue, Jun 2, 2009 at 1:52 AM, Gabriel Cosentino de Barros <
gbarros@yahoo-inc.com> wrote:

> Got the following error using the subversion checkout made now:
> Fatal error: Call to undefined function parseXmlError()
> in /var/www/shindig-svn/php/src/common/XmlError.php on line 35
>
> Think it was an error on this commit
>
> http://mail-archives.apache.org/mod_mbox/incubator-shindig-commits/200905.mbox/%3C20090510174450.DCEC223889D0@eris.apache.org%3E
>
> the author probably had a more complex xml parser installed that
> provided that missing global function. My install has the minimum
> requirements shown on the site and also, that same commit provides that
> funcionality by the next method, so I believe this is the intended
> behaviour:
>
> Index: php/src/common/XmlError.php
> ===================================================================
> --- php/src/common/XmlError.php (revision 780868)
> +++ php/src/common/XmlError.php (working copy)
> @@ -32,7 +32,7 @@
>       $xml = explode("\n", $xml);
>     }
>     foreach ($errors as $error) {
> -      $ret .= parseXmlError($error, $xml);
> +      $ret .= XmlError::display_xml_error($error, $xml);
>     }
>     libxml_clear_errors();
>     return $ret;
>
> cheers,
> --gbarros
>