You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/21 15:46:27 UTC

[GitHub] [superset] villebro edited a comment on issue #16975: [box plot] INT/NUMERIC types → DB engine Error, No numeric types to aggregate

villebro edited a comment on issue #16975:
URL: https://github.com/apache/superset/issues/16975#issuecomment-1018627141


   That's interesting - I saw that numpy has been bumped from 1.19.4 to 1.21.1 since 1.0.1, but I tried downgrading to that and the error is still the same. When I downgraded Pandas to 1.2.5 the error message changed, but it's still an error:
   
   ![image](https://user-images.githubusercontent.com/33317356/150555955-5f3a26a5-743e-4f16-b3a7-37e2bea1b9bc.png)
   
   Anyway, this should be a simple fix by converting `Double` to `float`, as we probably don't need the "correctly-rounded" types here - it's mostly a question of doing the conversion in the best possible place. Also, I noticed that the data type of `numeric_value` on Postgres isn't identified correctly, so that should also be fixed.
   
   ![image](https://user-images.githubusercontent.com/33317356/150556626-7a77dd7e-65a5-4328-a0a3-9615011a1de3.png)
   
   I suggest flagging this issue for 1.4.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org