You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 16:08:11 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #11394: Superset edit filter popover disappearing on hover
zuzana-vej opened a new issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394
The filter UI is more sensitive than before, leading to βcatch me if you canβ type of experience. When adding a filter to a chart (so in Explore view, you click on or trying to edit it, the popover containing filter settings disappears when moving the cursor from the filter to it (check out attached video). This doesn't happen all the time, but when it does, it's very frustrating.
Browser: Chrome
### Steps to Reproduce:
1. Create or open superset chart.
2. Click filter.
3. Hover to edit filter popover.
Result: Popover disappears.
Expected Result: Popover stays in place so I can edit the filter. Unfortunately not able to repro 100%. Happens sometimes... so planing to keep this bug open and keep checking if users encounter it again.
#### Screenshots
Step one: Click on a metric, filter box displays
<img width="325" alt="Screen Shot 2020-10-22 at 9 02 14 AM" src="https://user-images.githubusercontent.com/61221714/96899458-cbd58880-1445-11eb-92de-dd05197a3122.png">
Step two: Move mouse into the filter box - it disappears
<img width="284" alt="Screen Shot 2020-10-22 at 9 02 20 AM" src="https://user-images.githubusercontent.com/61221714/96899497-d5f78700-1445-11eb-9e1a-7298ae21a1c4.png">
### Environment
(please complete the following information):
- superset version: master
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714651868
πππ!
@eschutho could you please take a look at #11394, #11388 and #11379, i think they are all related. π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc removed a comment on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714655545
@eschutho could you please take a look at #11394, [#11388](https://github.com/apache/incubator-superset/issues/11388) and [#11379,](https://github.com/apache/incubator-superset/issues/11379) i think they are all related. π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
eschutho commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714857346
I have a quick fix, although I think the use of state vs props in the component could use some improvements. If you think it's worth pushing out a fix with the existing code, I can put up a PR now, or wait until next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714651868
πππ!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714826714
> sure, I'll take a look. Do you want to assign this to me?
let me know how long it's gonna take you. Kamil and Kasia can help π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-716423592
I'll check it out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714863626
https://github.com/apache/incubator-superset/pull/11163 @kgabryje Kamil~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
mistercrunch closed issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje removed a comment on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
kgabryje removed a comment on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-716423592
I'll check it out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
eschutho commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714759436
sure, I'll take a look. Do you want to assign this to me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714655545
@eschutho could you please take a look at #11394, [#11388](https://github.com/apache/incubator-superset/issues/11388) and [#11379,](https://github.com/apache/incubator-superset/issues/11379) i think they are all related. π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714598213
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.93. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714633273
Related to https://github.com/apache/incubator-superset/issues/11388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho edited a comment on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-714857346
I have a quick fix, although I think the use of state vs props in the component could use some improvements. If you think it's worth pushing out a fix with the existing code, I can put up a PR now and maybe Kamil and Kasia can help with the longer-term improvements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11394: Superset edit filter popover disappearing on hover
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11394:
URL: https://github.com/apache/incubator-superset/issues/11394#issuecomment-715472696
Here is another video recording when it disappears after user starts typing, if they move their mouse outside the popover area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org