[PR] feat(stream_routes): show disabled error [apisix-dashboard]

["SkyeYoung (via GitHub)" <gi...@apache.org>]

SkyeYoung opened a new pull request, #3130:
URL: https://github.com/apache/apisix-dashboard/pull/3130

   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [x] Test case
   
   **What changes will this PR take into?**
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(stream_routes): show disabled error [apisix-dashboard]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #3130:
URL: https://github.com/apache/apisix-dashboard/pull/3130#discussion_r2164333126


##########
src/components/page-slice/stream_routes/ErrorComponent.tsx:
##########
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import {
+  ErrorComponent,
+  type ErrorComponentProps,
+} from '@tanstack/react-router';
+import { AxiosError } from 'axios';
+
+import type { APISIXRespErr } from '@/config/req';
+
+export const StreamRoutesErrorComponent = (props: ErrorComponentProps) => {
+  if (props.error instanceof AxiosError) {
+    const err = props.error as AxiosError<APISIXRespErr>;
+    if (err.response?.status === 400) {
+      return <span>{err.response?.data.error_msg}</span>;
+    }
+    return <ErrorComponent {...props} />;
+  }

Review Comment:
   If props.error is not an instance of AxiosError, the component does not return any element. Add a fallback return (e.g., <ErrorComponent {...props} />) outside the if statement to ensure a consistent render.
   ```suggestion
     }
     return <ErrorComponent {...props} />;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(stream_routes): show disabled error [apisix-dashboard]

["SkyeYoung (via GitHub)" <gi...@apache.org>]

SkyeYoung merged PR #3130:
URL: https://github.com/apache/apisix-dashboard/pull/3130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org