You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/28 03:55:25 UTC
[GitHub] [arrow] wjones1 opened a new pull request #8790: ARROW-10755: [Rust] [Parquet] Add support for writing boolean type
wjones1 opened a new pull request #8790:
URL: https://github.com/apache/arrow/pull/8790
Built this based on what I saw existing for the numeric implementations. Most of it was already there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #8790: ARROW-10755: [Rust] [Parquet] Add support for writing boolean type
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#discussion_r532035226
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -665,6 +670,16 @@ where
values
}
+fn get_bool_array_slice(array: &arrow_array::BooleanArray) -> Vec<bool> {
+ let mut values = Vec::with_capacity(array.len() - array.null_count());
Review comment:
The logic that we were using was incorrect (at least once we get to lists). #8792 fixes this, so if it gets merged first, we would need to change this to populate values correctly .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #8790: ARROW-10755: [Rust] [Parquet] Add support for writing boolean type
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#discussion_r532036432
##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -1023,9 +1038,6 @@ mod tests {
}
#[test]
- #[should_panic(
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #8790: ARROW-10755: [Rust] [Parquet] Add support for writing boolean type
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #8790:
URL: https://github.com/apache/arrow/pull/8790
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8790: ARROW-10755: [Rust] [Parquet] Add support for writing boolean type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8790:
URL: https://github.com/apache/arrow/pull/8790#issuecomment-735036936
https://issues.apache.org/jira/browse/ARROW-10755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org